! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar's "open with" custom command doesn't escape the path
Status:
RESOLVED: FIXED

Comments

Description Guilherme Andrade 2014-05-10 22:07:29 CEST
Created attachment 5486 
Use case in action.

When trying to open a file with a custom command, the file selector for the desired executable doesn't escape the full path before setting the text widget's value, which in cases where the path contains spaces (for example) leads to a "Failed to execute application" error.
Comment 1 Guilherme Andrade 2014-05-10 22:09:57 CEST
Created attachment 5487 
Fix

Based on Midnight Commander's strutils_shell_escape() function.
Comment 2 Git Bot editbugs 2018-01-31 23:21:37 CET
Alexander Schwinn referenced this bugreport in commit 441d99d9052fea46431a5df3ee9def5487b1069e

Thunar's "open with" custom command doesn't escape the path (bug #10883)

https://git.xfce.org/xfce/thunar/commit?id=441d99d9052fea46431a5df3ee9def5487b1069e
Comment 3 alexxcons editbugs 2018-01-31 23:24:56 CET
Sorry for the late reply and thanks for the patch!

Sadly for thunar-master the patch did not work any more, since "thunar_util_str_shell_escape" was removed meanwhile.

However like that I already knew what to do ;)

Think I anyhow found a better way to fix this bug .. just take a look into the commit. 

Fix will be released within thunar 1.8.0
Comment 4 Guilherme Andrade 2018-01-31 23:33:28 CET
Wow, it's been a while. I barely recall having reported this - least of all having worked on a fix. But I'm glad it's been fixed. Thanks!
Comment 5 alexxcons editbugs 2018-01-31 23:39:08 CET
You are welcome .. better late than never :P

Bug #10883

Reported by:
Guilherme Andrade
Reported on: 2014-05-10
Last modified on: 2018-01-31

People

Assignee:
Jannis Pohlmann
CC List:
3 users

Version

Attachments

Use case in action. (47.86 KB, image/png)
2014-05-10 22:07 CEST , Guilherme Andrade
no flags
Fix (5.75 KB, patch)
2014-05-10 22:09 CEST , Guilherme Andrade
no flags

Additional information