! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Ineffective assignment in function pixbuf_thumbnailer_new_from_stream
Status:
RESOLVED: INVALID
Priority:
Medium
Severity:
normal
Product:
Tumbler
Component:
General

Comments

Description Mario Rugiero 2014-05-07 04:16:49 CEST 
Created attachment 5481 
Patch fixing the issue.

When there is no error, the pointer pointed by error should be assigned NULL, not error itself as it doesn't change anything outside the function. I attach a fix.
Comment 1 Jannis Pohlmann editbugs 2014-07-25 14:05:26 CEST 
commit dc74b5d38009a5f6c1064f69d8b7d632ae0b52a5
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Fri Jul 25 13:58:32 2014 +0200

    Fix setting internal error to NULL in pixbuf thumbnailer (bug #10878)
Comment 2 Nick Schermer editbugs 2014-07-28 11:43:12 CEST 
The patch is not correct, this idea of setting error to NULL to ignore further errors.
Comment 3 Nick Schermer editbugs 2014-07-28 18:20:14 CEST 
Reverted the commit and added comments.

Bug #10878

Reported by:
Mario Rugiero
Reported on: 2014-05-07
Last modified on: 2014-07-28

People

Assignee:
Jannis Pohlmann
CC List:
0 users

Version

Version:
unspecified
Target Milestone:
---

Attachments

Patch fixing the issue. (478 bytes, patch)
2014-05-07 04:16 CEST , Mario Rugiero 		no flags

Additional information