! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Applications Menu Icon not scaled correctly
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Applications Menu

Comments

Description Marcus Moeller 2014-05-02 18:11:39 CEST
Created attachment 5467 
panel icon not scaled correctly

In xfce4-panel 4.11, the applications menu icon is no longer scaled correctly. I have attached a screenshot to show the behavior.
Comment 1 Guido Berhoerster 2014-05-02 19:08:01 CEST
Adding in Andrzej who made the scaling improvements. And to further clarify, the image shown is a square 48x48 PNG image and the panel height is at 24 px.
Comment 2 Marcus Moeller 2014-05-02 19:13:30 CEST
If I increase the panel size to e.g. 26 and set it back to 24 px directly afterwards, the icon is showed in the correct size for the time the session is active.

After re-login, it is displayed as reported, again.
Comment 3 Andrzej editbugs 2014-05-02 22:24:49 CEST
Can you provide more information: good and bad panel version, gtk theme, icon/image (can you attach it?), exact settings and steps to reproduce the issue. For some reason I don't see this issue here.

Also, if you can recompile the panel from git, can you try reverting commit:
24d5634f2d13d1ff44dbbdf6dbf34d2ea27dd1ea

and maybe 65e9712bdd3f1f7013856ff8af0e311a57fa8d34 as well.
Comment 4 Guido Berhoerster 2014-05-02 22:30:55 CEST
Created attachment 5468 
button image

(In reply to Andrzej from comment #3)
> Can you provide more information: good and bad panel version, gtk theme,
> icon/image (can you attach it?), exact settings and steps to reproduce the
> issue. For some reason I don't see this issue here.

Looks good in xfce4-panel 4.10.1, issue started after upgrade to 4.11.0. The theme is Adwaita, image is attached here.
Comment 5 Andrzej editbugs 2014-05-03 01:19:35 CEST
I have spent quite some time debugging this issue but there is still no fix yet. A simple solution would be to revert 24d5634f2d13d1ff44dbbdf6dbf34d2ea27dd1ea but that commit was fixing other scaling issues in XfcePanelImage. The current version uses GtkImage and scales the icons manually. This works well with all styles I tried, except Adwaita.

The specific issue is that on startup style->[x|y]thickness=2, and after e.g. panel size change it switches to 4|3. I don't know if it is a bug in the plugin or adwaita theme or why it happens.
Comment 6 Marcus Moeller 2014-05-03 07:59:21 CEST
I have already tried to work together with the Adwaita devs in the past, and it was quite hard. They do not really care about non-gnome DEs. The thing is, that Adwaita is the default GTK theme on many distros like openSUSE, Fedora ...
Comment 7 Guido Berhoerster 2014-05-03 11:06:13 CEST
(In reply to Marcus Moeller from comment #6)
> I have already tried to work together with the Adwaita devs in the past, and
> it was quite hard. They do not really care about non-gnome DEs. The thing
> is, that Adwaita is the default GTK theme on many distros like openSUSE,
> Fedora ...

At least on openSUSE I'd use something else that better fits the SUSE branding but there is little choice of quality themes that are consistent across GTK 2 and 3 with developers able or willing to keep up with GTK 3 which breaks themes on every minor release. I guess that's applies to other distros as well which will eventually run into this issue too, so maybe it is still worth asking?
Comment 8 Andrzej editbugs 2014-05-29 00:11:33 CEST
Should be fixed in:

85e08f7 ApplicationsMenu: fixed wrong initial icon size in some themes

Some theme parameters (e.g. xthickness) are changing at runtime after initial widget instantiation. So we have to listen to style-set events and force button resize.
Comment 9 Simon Steinbeiss editbugs 2018-05-01 08:06:40 CEST
Judging from the last comment this issue should be fixed (plus I can't reproduce it). Closing the report for now (feel free to re-open if you can still reproduce it).

Bug #10865

Reported by:
Marcus Moeller
Reported on: 2014-05-02
Last modified on: 2018-05-01

People

Assignee:
Nick Schermer
CC List:
3 users

Version

Version:
Unspecified

Attachments

panel icon not scaled correctly (16.11 KB, image/png)
2014-05-02 18:11 CEST , Marcus Moeller
no flags
button image (2.19 KB, image/png)
2014-05-02 22:30 CEST , Guido Berhoerster
no flags

Additional information