! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Grouped icons are not rendered with transparent effect when their child are a...
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Window Buttons

Comments

Description amigamagic 2014-05-02 02:51:45 CEST
Created attachment 5465 
Diff file with the bugfix

package: xfce4-panel-4.11.0
plugin: tasklist

Minimized icons in the tasklist are rendered with a certain transparency factor, but actually this doesn't apply to grouped icons. To mantain a consistent behaviour, when "all" the windows inside a group are minimized the grouped icon should be transparent too.

I attached a bugfix.

Cheers,
amigamagic
Comment 1 amigamagic 2014-05-02 14:28:16 CEST
Created attachment 5466 
Diff file with the bugfix (v2)

Fixed another bug: let's suppose you selected to display only the minimized icons in the tasklist. Now if you open a new window of a different type from the ones currently in the tasklist, and then minimize it, its icon will be displayed without transparency. This is inconsistent with the expected behaviour, so I fixed it.
Comment 2 Andrzej editbugs 2015-02-15 00:58:32 CET
Pushed to git (v2). It fixes the second issue (transparency of minimized new windows) but the first one is still there (grouped icons are are opaque even when all their windows are minimized).
Comment 3 Steve Dodier-Lazaro editbugs 2015-02-15 03:16:31 CET
Please try to git apply --check yourpatch.patch before submitting, to spot and remove all trailing whitespaces :-)
Comment 4 Steve Dodier-Lazaro editbugs 2015-02-15 03:24:14 CET
Otherwise, just as for Andre: neither patch 5465 or 5466 fix the reported issue. They appear to be doing nothing.

Amigamagic, could you please tell us how you tested this patch?
Comment 5 Simon Steinbeiss editbugs 2018-11-30 16:47:06 CET
I've rebased this patch on top of current master, but I still see at least one issue I would like to fix before merging this:
- when a single window is minimized and you then open a second window of that application, the icon remains 70% translucent, so there's at least one unhandled signal/case (active_window_changed or whatever)
- the exo stuff should be replaced by style-classes and something like "button image { opacity: 0.7; }"
Comment 6 Simon Steinbeiss editbugs 2018-11-30 16:57:25 CET
Ok, part one is done. I'll try to replace exo too and then push this.
Comment 7 Git Bot editbugs 2018-12-01 01:06:10 CET
Simon Steinbeiss referenced this bugreport in commit 9921b874b7c929696eca061b8818303d3e439a93

tasklist: Make all-minimized group buttons translucent (Bug #10862)

https://git.xfce.org/xfce/xfce4-panel/commit?id=9921b874b7c929696eca061b8818303d3e439a93

Bug #10862

Reported by:
amigamagic
Reported on: 2014-05-02
Last modified on: 2018-12-01

People

Assignee:
Simon Steinbeiss
CC List:
3 users

Version

Version:
4.10.1

Attachments

Diff file with the bugfix (3.49 KB, patch)
2014-05-02 02:51 CEST , amigamagic
no flags
Diff file with the bugfix (v2) (3.98 KB, patch)
2014-05-02 14:28 CEST , amigamagic
no flags

Additional information