Run of `./configure --disable-file-icons --disable-thunarx` causes configure.ac.in because of <snip> if test "x$enable_desktop_icons" = "xyes" -a "x$enable_file_icons" = "xyes"; then dnl here i shall abuse the XDT_CHECK_PACKAGE macro XDT_CHECK_PACKAGE([DBUS], [dbus-glib-1], [dbus_minimum_version], [], [ </snip> the compile to fail because at least common/xfdesktop-thumbnailer.c has #include <dbus/dbus-glib.h> without anykind of #ifdef later like: <snip> libtool: compile: x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -DNDEBUG -I../src -I/usr/include/xfce4 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2 -DDBUS_API_SUBJECT_TO_CHANGE -O2 -pipe -march=native -frecord-gcc-switches -Wimplicit-function-declaration -c xfdesktop-thumbnailer.c -fPIC -DPIC -o .libs/libxfdesktop_la-xfdesktop-thumbnailer.o xfdesktop-thumbnailer.c:39:28: fatal error: dbus/dbus-glib.h: No such file or directory #include <dbus/dbus-glib.h> ^ compilation terminated. Makefile:516: recipe for target 'libxfdesktop_la-xfdesktop-thumbnailer.lo' failed </snip> Looks like the "if test "x$enable_desktop_icons" = "xyes" -a "x$enable_file_icons" = "xyes";" type of code should be dropped from configure.ac so that dbus-glib is always checked if it's purposely made a new non-optional dependency
Same problem in 'src/xfdesktop-file-utils.c' and 'src/xfdesktop-file-utils.h' because src/Makefile.am always compiles them, and they are without #ifdef in the .c and .h
Created attachment 5383 Always depend on dbus-glib If the change was intention, then this should be applied too
*intentional, sorry for bugspam
Good catch, thanks for the patch. Pushed to master in: http://git.xfce.org/xfce/xfdesktop/commit/?id=f0e5154a5ff15f4d12d08cbc7f044641fa5b768e