! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Unify keyboard shortcuts treatment via priority flag
Status:
RESOLVED: MOVED
Product:
Xfce4-settings
Component:
Keyboard Settings

Comments

Description Mr and Mrs D 2014-03-09 18:52:57 CET
There are two screens i am aware of i can set hotkeys - `App Menu > Settings > Keyboard > application shortcuts tab`  and `App Menu > Settings > Window Manager > Keyboard tab`. This led me to surprises as Ctrl+Alt+D showed me the desktop instead of Dropbox.

Expected: common namespace for shortcuts - conflicts are resolved with a priority system (exposed in the UI). As of now the Window Manager shortcuts (show desktop) have highest priority but that is not necessary.

The window manager should be the central point of control - the App Menu > Settings > Keyboard > application shortcuts tab should managed by the window manager and applications (including the xfce session) should register their shortcuts there. If they do not their shortcuts should by default have the lowest priority. The system should be extendible with scripts
Comment 1 Eric Koegel editbugs 2014-11-05 17:50:42 CET
Moving to xfce4-settings as that module handles keyboard shortcut settings.
Comment 2 Steve Dodier-Lazaro editbugs 2014-11-05 23:32:40 CET
An easier to code solution (and possibly nicer for end users) would be for each UI to inform the user that a key they have chosen is already in use by the other component, highlighting a link to the other component to let the user navigate over there in case they want to change the other end's shortcut to resolve the conflict.

Optionally each UI component could contain a permanent link to the other one to let users know there are two UIs for shortcuts.

This would only involve coding up a few functions and adding a few widgets rather than entirely redesigning the UIs existing and code logic. Comments welcome!
Comment 3 Steve Dodier-Lazaro editbugs 2014-11-21 03:48:46 CET
https://bugzilla.xfce.org/show_bug.cgi?id=7845 is similar in that it concerns conflicts between similar shortcuts (it is NOT a duplicate however).

Redesigns should also account for possible priority conflicts *within* a window caused by how modifiers are handled. Solutions such as ordering items by priority would be hard to apply given we have two disjoint UIs.
Comment 4 Mr and Mrs D 2014-11-21 10:29:59 CET
Moved away but glad to see people working on this.

My advice - _do not monkeypatch this_. If there is one _central_ UI component this is the shortcuts.

Leave one and only one place where one can set the shortcuts (the App Menu > Settings > Window Manager > Keyboard tab) and implement handling of conflicts.
Comment 5 Git Bot editbugs 2020-05-28 22:59:29 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-settings/-/issues/41.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #10743

Reported by:
Mr and Mrs D
Reported on: 2014-03-09
Last modified on: 2020-05-28

People

Assignee:
Jérôme Guelfucci
CC List:
6 users

Version

Version:
unspecified

Attachments

Additional information