10731 – Firefox opens muliple tabs when html filename has blank spaces, using each word as a URL.

Firefox opens muliple tabs when html filename has blank spaces, using each wo...

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Exo

Component:

Helpers

Comments

Description jeff 2014-03-06 10:31:08 CET

I traced the problem to this file: /usr/share/xfce4/helpers/firefox.desktop

When I changed the existing line:

X-XFCE-CommandsWithParameter=%B -remote "openURL(%s)";%B %s;

To this (adding quotes to %s):

X-XFCE-CommandsWithParameter=%B -remote "openURL(%s)";%B "%s";

the problem went away.

Comment 1 Yves-Alexis Perez editbugs

2014-08-07 21:26:14 CEST

Can someone take a look a this?

Comment 2 Sergey Urushkin 2014-11-19 10:48:54 CET

Created attachment 5757 
helpers.patch

I think all helpers should be fixed. Here is the patch.

Comment 3 Sean Davis editbugs

2015-02-16 23:05:05 CET

Thanks for the bug report and patch. Fixed in http://git.xfce.org/xfce/exo/commit/?id=8cd3233f1d2312670444a202f79d55b98286aa4f

Comment 4 Evangelos Foutras 2015-03-01 19:07:12 CET

Unfortunately, this patch breaks invocations such as the following:

$ exo-open --launch TerminalEmulator screen -S test

The resulting error is:

  Failed to execute child
  Failed to execute child process "screen -S test" (No such file or directory)

The expected outcome would be to open a terminal emulator window that executes the command "screen -S test".

'exo-open --help' confirms that this behavior is indeed incorrect:

=========
Else, if you specify the --launch option, you can select which preferred application you want to run, and pass additional parameters to the application (i.e. for TerminalEmulator you can pass the command line that should be run in the terminal).
=========

At least the changes to xfce4-terminal.desktop.in.in need to be reverted. I'm not sure how the other terminals behave but we could possibly test them.

Comment 5 Steve Dodier-Lazaro editbugs

2015-03-01 19:10:44 CET

Reopening as the patch has had unwanted side effects, as per Evangelos' last comment

Comment 6 Evangelos Foutras 2015-03-01 20:53:25 CET

Created attachment 6022 
Don't quote arguments passed to terminal emulators

This is my proposed patch. It basically reverts the quoting changes made to all terminal emulator helpers except for Sakura which weirdly enough doesn't work without quotes.

I briefly checked all terminals except the Debian one and nxterm, and they behave correctly after the patch. If I remember correctly, qterminal and xterm also worked fine with quotes.

Comment 7 Landry Breuil editbugs

2015-03-02 22:18:28 CET

*** Bug 11634 has been marked as a duplicate of this bug. ***

Comment 8 Sean Davis editbugs

2015-03-05 21:15:39 CET

Thanks for additional test and a new patch.  Applied at http://git.xfce.org/xfce/exo/commit/?id=b4200c9bab9f60e61a100dd12d841c2588b360d8

Bug #10731

Reported by:
jeff

Reported on: 2014-03-06
Last modified on: 2015-03-05

Duplicates (1):

11634 open composed command in terminal broken after commit 8cd3233f

People

Assignee:
Nick Schermer

CC List:
7 users

Version

Version:
0.8.0

Target Milestone:
Exo 0.3

Attachments

helpers.patch (6.94 KB, patch) 2014-11-19 10:48 CET , Sergey Urushkin	no flags
Don't quote arguments passed to terminal emulators (4.84 KB, patch) 2015-03-01 20:53 CET , Evangelos Foutras	no flags

Additional information