! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfdesktop-settings opens in seperate window
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description flocculant 2014-02-26 11:22:37 CET
Previously opening desktop settings from the Settings Manager, it used to open in the same window with an option to return to "All Settings" 

Now it opens in a seperate window of it's own.

xfdesktop4 - version 4.11.3-1ubuntu1

Xubuntu Beta 1
Comment 1 Thaddaeus Tintenfisch editbugs 2014-02-26 14:57:59 CET
http://git.xfce.org/xfce/xfdesktop/commit/settings/xfce-backdrop-settings.desktop.in?id=af240b063cd0678dc1739ffa28e93f1ff530bead

This commit has changed the value of X-XfcePluggable to 'false'. Reverting the value back to 'true' seems to break the preselected backdrop folder.
Comment 2 Eric Koegel editbugs 2014-02-26 17:30:05 CET
Yeah, there's an issue with xfdesktop-settings being used
as a plug. The cb_window_opened function tries to match the
WnckWindow against its GtkWindow but I haven't found a way
to get that to work when it's a gtkplug. This is the function
in question:
http://git.xfce.org/xfce/xfdesktop/tree/settings/main.c#n1532

In the commit you linked to, it used to use the functions:
wnck_screen_force_update(wnck_screen);
and then
panel->wnck_window = wnck_screen_get_active_window(wnck_screen);
which didn't always work especially since the wnck docs say:
"May return NULL sometimes, since not all window managers
guarantee that a window is always active."
Comment 3 Eric Koegel editbugs 2014-03-03 17:56:02 CET
Created attachment 5378 
Make xfdesktop-settings pluggable again

The proposed patch changes it back to allowing
xfdesktop-settings to be embedded inside xfce's
settings dialog. If possible, please test this
out, thanks!
Comment 4 Simon Steinbeiss editbugs 2014-03-03 18:27:16 CET
Just tested the patch and it works for me!

Bug #10714

Reported by:
flocculant
Reported on: 2014-02-26
Last modified on: 2014-03-04

People

Assignee:
Eric Koegel
CC List:
3 users

Version

Version:
Unspecified

Attachments

Additional information