! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-terminal --drop-down does not move move to the top of the screen automa...
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description James McGuire 2014-02-26 07:29:50 CET
Created attachment 5374 
patch for xfce4-terminal bug

Steps to reproduce bug in 0.6.3

1. Set animation duration to 0ms
2. Open up a xfce4-terminal --drop-down
3. alt+mouse to move the terminal
4. Make the terminal lose focus
5. Reopen the dropdown terminal

Expected results:
Terminal reopens at top of screen

Actual results:
Terminal reopens wherever you moved it
show
I have had this happen occasionally when switching screens around on my laptop.

Troubleshooting:
terminal-window-dropdown.c -> terminal_window_dropdown_show
I would assume that gtk_window_move() should move the window to the proper position, but it doesn't seem to. If you move the gtk_window_move() call below gtk_window_present_with_time() some cursory googling indicates that some window managers will ignore move requests on hidden windows.

Assuming that the issue is fixed by moving the window-move to below the visibility toggle the attached patch should solve the problem.
Comment 1 Sam 2014-07-29 16:37:44 CEST
I can confirm that James' patch works. Thanks!
Comment 2 Igor editbugs 2016-07-05 20:29:44 CEST
Hmm, I don't get it - why would you expect the window to show up at top of the screen? You've moved it to another position and it shows up there. This seems logical to me.
Comment 3 James McGuire 2016-07-05 20:43:15 CEST
The idea is that it is supposed to be anchored to the top (or wherever) of your screen. If you set the animation speed to anything over 0ms it will do that properly. It's the entire reason that there is a window move in the code already.
Comment 4 Igor editbugs 2016-07-06 08:24:07 CEST
Still, it seems unnatural to me that window position gets lost after the window is minimized and restored.
I think it's rather a bug in the animation implementation that moves the window back to the top of the screen.
Comment 5 Igor editbugs 2016-08-05 15:42:14 CEST
After the recent commits, the window is no longer moved to the top of the screen, but stays where it was moved to. I think this behavior is consistent and reasonable.
Comment 6 James McGuire 2016-08-05 17:40:12 CEST
I might as well make one last attempt to convince you:  If you look at every other quake style terminal the default is always to have it drop down from the top of the screen. Please do a google image search or something because starting from the top and dropping down is the behavior of every other similar terminal.
Comment 7 Igor editbugs 2016-08-05 17:52:34 CEST
(In reply to James McGuire from comment #6)
> I might as well make one last attempt to convince you:  If you look at every
> other quake style terminal the default is always to have it drop down from
> the top of the screen. Please do a google image search or something because
> starting from the top and dropping down is the behavior of every other
> similar terminal.
And you have convinced me :)
I'm not a big drop-down terminals user, bug now I've checked guake and seen that it's behaving according to your description, so I believe you that this is common behavior.
Thanks for the patch!

Bug #10713

Reported by:
James McGuire
Reported on: 2014-02-26
Last modified on: 2016-08-05

People

CC List:
3 users

Version

Version:
unspecified

Attachments

patch for xfce4-terminal bug (1015 bytes, patch)
2014-02-26 07:29 CET , James McGuire
no flags

Additional information