Created attachment 5364 Patch for focus problem under GNOME Shell/Mutter This bug happens under GNOME Shell/Mutter (I tried it with version 3.10) **Steps to reproduce** 0- Set key bindings for Terminal (e.g., Ctr-Alt-T) and TerminalDropdown (e.g., F12). 1- Open Firefox and maximize it, make sure it has the focus. 2- a) Press the key binding for Terminal (Ctrl-Alt-T). Notice that the window isn't raised above the Firefox one and it doesn't "steal" the focus either. b) With Firefox focused, press the key binding for TerminalDropdown (F12). Notice that even though the dropdown window is drawn above Firefox, it doesn't have the focus (Firefox's window still has it). I've checked that the patch I attached works on different distros (Debian sid, Arch, Ubuntu trusty) without any obvious regression. The problematic line says: > /* this is required to get the geometry right > * later in the terminal_window_add() call. > */ > gtk_widget_hide (GTK_WIDGET (terminal)); My hunch is that the problem this line tried to solve/work around is obsoleted... Or maybe I am missing something :-)
I must a little bit more specific about the distros on which I tested this patch: - Debian sid with Xfce4 - Ubuntu trusty with Unity - Arch Linux with GNOME Shell (vanilla)
Hm, I am checking again (under GNOME Shell) but my patch doesn't seem to work, a false positive :(
Hm! I just noticed that the problem is related to the drop-down mode: if I have the drop-down running (even if hidden) the bug is reproducible especially if Firefox's location bar has the focus, otherwise I cannot seem to be able to reproduce it. So, checking with both Nautilus and Firefox location bars, I get: - GtkEntry focused + Drop-down terminal (in hidden or not) == 100% reproducible. It's weird that it's not a reproducible behavior unless the drop-down mode is running. I'll see if I find a patch that works :-) (Nonetheless, I still don't know if the line of code I remove is useful nowadays, since not having it doesn't seem to be problematic...)
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-terminal/-/issues/5. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev