! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Set override-redirect on xfce4-notifyd window
Status:
RESOLVED: FIXED
Product:
Xfce4-notifyd
Component:
general

Comments

Description liquider 2014-02-11 19:56:08 CET
Hi,

In xfce4-notifyd/xfce-notify-window.c around line 214 in xfce_nofify_window_init() function [1], would you please consider adding a call:

    gdk_window_set_override_redirect(GTK_WINDOW(window), TRUE);

The GDK documentation says: "An override redirect window is not under the control of the WM. ... it won't have a titlebar, won't be minimizable, ..."
This is kind of in accordance with the nearby code lines.

Without this, the window managers not honoring whatever flag set by gtk_window_set_decorated() still decorate and, in case of e.g. i3wm, even tile the window.

I can provide a patch. :-)

Thank you.

[1]: http://git.xfce.org/apps/xfce4-notifyd/tree/xfce4-notifyd/xfce-notify-window.c?id=b9959b2b2264d81e9bbcb2b3fc495e4d30b63061#n214
Comment 1 liquider 2014-02-11 20:44:39 CET
Sorry, having absolutely no idea what I'm talking about, I appear to have mixed GtkWindow and GdkWindow.

I suppose the more correct line number is around 318 [1] in the xfce_notify_window_realize() function (or after the window has been realized), and the line:

    gdk_window_set_override_redirect(gtk_widget_get_window(widget), true);

Thanks.

[1]: http://git.xfce.org/apps/xfce4-notifyd/tree/xfce4-notifyd/xfce-notify-window.c?id=b9959b2b2264d81e9bbcb2b3fc495e4d30b63061#n318
Comment 2 liquider 2014-02-12 01:00:11 CET
Ok, the canonical way to solve this is to honor _MOTIF_WM_HINTS, so this request is likely, regardless of what "override redirect" achieves, invalid.
Sorry.
Comment 3 liquider 2014-02-15 21:29:29 CET
No, _MOTIF_WM_HINTS is about window decorations. This bug is about xfce4-notifyd notification windows being managed at all. Comment #2 applies.
Comment 4 Jérôme Guelfucci editbugs 2014-02-16 14:10:22 CET
Thank you for your contribution, I just pushed this to the git master branch.

Cheers,

Jérôme
Comment 5 Alistair Buxton 2014-02-17 21:09:42 CET
*** Bug 10384 has been marked as a duplicate of this bug. ***

Bug #10686

Reported by:
liquider
Reported on: 2014-02-11
Last modified on: 2014-02-17
Duplicates (1):
  • 10384 "Always on top" windows steal focus after notification is displayed.

People

Assignee:
Jérôme Guelfucci
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information