! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
functions for Keywords desktop key


Description liquider 2014-02-10 19:36:20 CET

It would be useful if garcon provided an interface for Keywords desktop entry [1], like garcon_menu_item_get_keywords, garcon_menu_item_set_keywords, ...

[1]: http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys
Comment 1 Gregor Santner 2017-10-12 23:03:04 CEST
Can somebody point me to where this could be inserted? This shouldn't be more work than a simple string split on semicolon + a getter. This is one of the most missing features of garcon for me.
Comment 2 liquider 2017-10-13 03:44:47 CEST
This is C, not Python.

Comment 3 Gregor Santner 2017-10-13 11:50:11 CEST
Created attachment 7363 
Suuport for keywords in freedesktop compliant files, v1
Comment 4 Gregor Santner 2017-10-13 11:51:24 CEST
Created attachment 7364 
tried using keyword function in xfdashboard. printed out first keyword (if available)
Comment 5 Gregor Santner 2017-10-13 11:53:50 CEST
Can you take a look at submission?
This is my first contribution to XFCE, I tried to follow the conventions.
Most of the code is done quite like categories.

KEYWORD type is not defined in GLIB, so I added that in the header.
You can verify correctness here: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
Comment 6 liquider 2017-10-14 20:50:53 CEST
Looks good to my amateur eyes. You should get a maintainer to review it. Raise it on xfce4-dev@ to speed it up.
Comment 7 Gregor Santner 2017-10-14 20:54:39 CEST
how to? do you mean a mailing list, or a group to mention?
Comment 8 liquider 2017-10-14 21:07:21 CEST
Yes, sorry, the mailing list. "A group to mention," lmao, this is Bugzilla, a 90's software! :D

Comment 9 Gregor Santner 2017-10-14 21:08:38 CEST
yes , but it supports assigning and adding to CC list :D
Comment 10 Eric Koegel editbugs 2017-10-23 15:00:35 CEST
Thanks for the patch! Pushed to master in: https://git.xfce.org/xfce/garcon/commit/?id=a38922c0892262294c88813c4bf0c72e2f438d54

Bug #10683

Reported by:
Reported on: 2014-02-10
Last modified on: 2017-10-23


Jannis Pohlmann
CC List:
2 users




Additional information