I just ran the static analysis tool cppcheck
over the source code of xfce4-taskmanager-1.0.1
It said many things, including
[process-tree-view.c:314]: (style) Array index 'i' is used before limits check.
Source code is
for (i = 0; columns_positions_split[i] != NULL && i < N_COLUMNS; i++)
for (i = 0; i < N_COLUMNS && columns_positions_split[i] != NULL; i++)
would be better code. I also checked the latest code online
and the problem exists there also.
interestingly cppcheck doesnt complain here, what arguments did you use ?
What were the other 'many things' ?
(In reply to Landry Breuil from comment #1)
> interestingly cppcheck doesnt complain here, what arguments did you use ?
> What were the other 'many things' ?
I've no idea. I filed this bug nearly ten months ago, and the
relevant data has seen been deleted.
Any bug report not answered in six months is deemed to be dead
and any relevant data is deleted.
I suggest you run cppcheck with flag --enable-all over
your current source code and investigate what it says.
Funny, even with --enable=all cppcheck 1.67 doesnt yield this message here, i suppose it depends on the underlying compiler version or the environment.
Applied anyway in 095098f8, thx.