! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Desktop icons/labels are not properly themed after login


Description Thaddaeus Tintenfisch editbugs 2014-01-05 21:46:54 CET
Created attachment 5300 
left OK, right not properly themed

xfdesktop fails to apply the correct theme to desktop elements after starting the Xfce session. This happens quite often and can be fixed by reloading xfdesktop or adding an additional startup delay (1 sec) to xfdesktop.

Xubuntu 14.04 Daily Build
xfdesktop 4.11.2
Comment 1 Eric Koegel editbugs 2014-01-18 16:52:40 CET
Created attachment 5322 
Wait for the settings manager at startup

If xfdesktop starts loading the icon view before the settings
manager has been set to the screen then the icons will appear
as if they aren't themed. This patch has xfdesktop wait for
the settings manager the same way it already does for the window
Let me know if this patch solves the issue for you.
Comment 2 Thaddaeus Tintenfisch editbugs 2014-01-19 11:58:02 CET
The patch does not solve the problem. xfdesktop waits for xfwm4 and now additionally for xfsettingsd or simply starts after the 5sec timeout. In the latter case xfdesktop will not update its appearance once the slower starting xfsettingsd is up and running.
Comment 3 Eric Koegel editbugs 2014-01-25 16:40:36 CET
Created attachment 5334 
Refresh desktop on style changes

Xfdestkop's icon view doesn't update the icon labels when xfsettingsd
starts up. To work around that, refresh the desktop on a style change
event. Additionally gtk likes to send up to 10 style change events at
once, so this also adds a 1 second delay to ensure it's the last change
event that we respond to.

I couldn't figure out how to get the icon view to update the settings
for the icon text when xfsettingsd makes its changes. Let me know if
this fixes it, even if it's not my favorite way to work around the bug.
Comment 4 Thaddaeus Tintenfisch editbugs 2014-01-25 23:27:05 CET
The new patch fixes this issue and also the related bug 10642.
Comment 5 Eric Koegel editbugs 2014-01-26 05:38:09 CET
Thanks for testing the patches, pushed to master in:
Comment 6 Thaddaeus Tintenfisch editbugs 2014-01-26 16:34:28 CET
Changing the desktop icon size twice seems to freeze xfdesktop now.

*** Error in `xfdesktop': free(): corrupted unsorted chunks: 0x09250310 ***
*** Error in `xfdesktop': malloc(): memory corruption: 0x094484d0 ***
Comment 7 Eric Koegel editbugs 2014-01-27 10:21:49 CET
Created attachment 5337 
icon resize issue

git bisecting it shows it was this change that broke it:
This patch should fix the resize issue. Thanks for pointing out the bug.
Comment 8 Thaddaeus Tintenfisch editbugs 2014-01-27 12:36:00 CET
I can confirm that the last patch resolves the resize issue.
Comment 9 Eric Koegel editbugs 2014-01-27 16:19:23 CET
Thanks for testing it, pushed to master in: http://git.xfce.org/xfce/xfdesktop/commit/?id=b730aad939db6b8ab5b99e5e4873c7540f7e2be0
Comment 10 Thaddaeus Tintenfisch editbugs 2014-03-20 09:24:02 CET
This issue seems to be back in 4.11.4. I've encountered it several times already and will do some test runs without this particualar commit:

Comment 11 Thaddaeus Tintenfisch editbugs 2014-03-21 00:20:31 CET
Commit 81e3969103a4b2fc705322bd9afee4e415934f80 is indeed responsible for this regression.
Comment 12 Eric Koegel editbugs 2014-03-24 17:37:15 CET
I'd rather not revert back if we can help it.

Since xfdesktop responds to xfsettingsd being
launched and exiting I'm going to assume the
style set messages do work and it might be a
simple race condition between the two at start.
Especially since both are waiting for the window
manager. Can you try killing xfdesktop, clearing
any saved sessions, starting xfdesktop with the
-D option, and restarting to see if that fixes
the issue. Thanks!
Comment 13 Thaddaeus Tintenfisch editbugs 2014-03-25 13:41:56 CET
Adding the -D option did not help.
Comment 14 Thaddaeus Tintenfisch editbugs 2014-03-27 13:26:21 CET

I've tested this commit and it resolves the issue.
Comment 15 Eric Koegel editbugs 2014-03-27 16:57:59 CET
Thanks for testing it out, pushed to master:

Bug #10605

Reported by:
Thaddaeus Tintenfisch
Reported on: 2014-01-05
Last modified on: 2014-03-27


Eric Koegel
CC List:
1 user




left OK, right not properly themed (69.09 KB, image/png)
2014-01-05 21:46 CET , Thaddaeus Tintenfisch
no flags
Wait for the settings manager at startup (3.75 KB, patch)
2014-01-18 16:52 CET , Eric Koegel
no flags
Refresh desktop on style changes (2.68 KB, patch)
2014-01-25 16:40 CET , Eric Koegel
no flags
icon resize issue (3.03 KB, patch)
2014-01-27 10:21 CET , Eric Koegel
no flags

Additional information