Created attachment 5300 left OK, right not properly themed xfdesktop fails to apply the correct theme to desktop elements after starting the Xfce session. This happens quite often and can be fixed by reloading xfdesktop or adding an additional startup delay (1 sec) to xfdesktop. Xubuntu 14.04 Daily Build xfdesktop 4.11.2
Created attachment 5322 Wait for the settings manager at startup If xfdesktop starts loading the icon view before the settings manager has been set to the screen then the icons will appear as if they aren't themed. This patch has xfdesktop wait for the settings manager the same way it already does for the window manager. Let me know if this patch solves the issue for you.
The patch does not solve the problem. xfdesktop waits for xfwm4 and now additionally for xfsettingsd or simply starts after the 5sec timeout. In the latter case xfdesktop will not update its appearance once the slower starting xfsettingsd is up and running.
Created attachment 5334 Refresh desktop on style changes Xfdestkop's icon view doesn't update the icon labels when xfsettingsd starts up. To work around that, refresh the desktop on a style change event. Additionally gtk likes to send up to 10 style change events at once, so this also adds a 1 second delay to ensure it's the last change event that we respond to. I couldn't figure out how to get the icon view to update the settings for the icon text when xfsettingsd makes its changes. Let me know if this fixes it, even if it's not my favorite way to work around the bug.
The new patch fixes this issue and also the related bug 10642.
Thanks for testing the patches, pushed to master in: http://git.xfce.org/xfce/xfdesktop/commit/?id=1516cb96c6ec9b20b63f05e7bcc4af8594d43129
Changing the desktop icon size twice seems to freeze xfdesktop now. *** Error in `xfdesktop': free(): corrupted unsorted chunks: 0x09250310 *** *** Error in `xfdesktop': malloc(): memory corruption: 0x094484d0 ***
Created attachment 5337 icon resize issue git bisecting it shows it was this change that broke it: http://git.xfce.org/xfce/xfdesktop/commit/?id=3aeedbb076b1315b56e43e798694425657569abe This patch should fix the resize issue. Thanks for pointing out the bug.
I can confirm that the last patch resolves the resize issue.
Thanks for testing it, pushed to master in: http://git.xfce.org/xfce/xfdesktop/commit/?id=b730aad939db6b8ab5b99e5e4873c7540f7e2be0
This issue seems to be back in 4.11.4. I've encountered it several times already and will do some test runs without this particualar commit: http://git.xfce.org/xfce/xfdesktop/commit/?id=81e3969103a4b2fc705322bd9afee4e415934f80
Commit 81e3969103a4b2fc705322bd9afee4e415934f80 is indeed responsible for this regression.
I'd rather not revert back if we can help it. Since xfdesktop responds to xfsettingsd being launched and exiting I'm going to assume the style set messages do work and it might be a simple race condition between the two at start. Especially since both are waiting for the window manager. Can you try killing xfdesktop, clearing any saved sessions, starting xfdesktop with the -D option, and restarting to see if that fixes the issue. Thanks!
Adding the -D option did not help.
https://github.com/EricKoegel/xfdesktop/commit/31a6f3520565bd59701c78e5e030e113eea7f406 I've tested this commit and it resolves the issue.
Thanks for testing it out, pushed to master: http://git.xfce.org/xfce/xfdesktop/commit/?id=cdbba947379540fa2c89fda34b96bf336070fe47