! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
panel-plugin/Makefile.am is misusing LDFLAGS for passing libraries to the lin...
Status:
RESOLVED: WONTFIX
Component:
clock-plugin

Comments

Description Samuli Suominen 2013-12-10 16:40:10 CET
Currently orage is building by cheer luck on most systems, even with -Wl,--as-needed, but with the new binutils version and the new GNU GOLD linker, things will fall apart as they should...

Basically if LDFLAGS is used instead of LDADD (or LIBADD) then the libraries go to wrong location in the final linker command line, causing them to be ignored altogether

The mistake and fix should be obvious:

--- panel-plugin/Makefile.am
+++ panel-plugin/Makefile.am
@@ -9,7 +9,7 @@
 	-DPACKAGE_LOCALE_DIR=\"$(localedir)\"			\
 	@LIBXFCE4PANEL_CFLAGS@
 
-xfce4_orageclock_plugin_LDFLAGS =					\
+xfce4_orageclock_plugin_LDADD =					\
 	@LIBXFCE4PANEL_LIBS@                            \
 	-lX11
 
@@ -25,7 +25,7 @@
     ../src/functions.h
 
 if HAVE_CYGWIN
-xfce4_orageclock_plugin_LDFLAGS +=                 \
+xfce4_orageclock_plugin_LDFLAGS =                 \
 	-no-undefined
 endif
Comment 1 Samuli Suominen 2013-12-10 16:42:31 CET
This bug would autoresolve itself if the plugin is converted to the new plugin module format, when converting Makefile.am and use libtool's _LIBADD with it

Just saying, dunno why the 4.10.0 release is still using the deprecated format
Comment 2 Skunnyk editbugs 2019-10-27 18:39:26 CET
The orage project is not maintained anymore and has been archived. Closing bugs.

Bug #10536

Reported by:
Samuli Suominen
Reported on: 2013-12-10
Last modified on: 2019-10-27

People

CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information