Static analysis tool cppcheck said many things, including [icon_bar.c:1385] -> [icon_bar.c:1385]: (style) Same expression on both sides of '&&'. Source code is if (G_LIKELY (item->width != -1 && item->width != -1)) return; Maybe if (G_LIKELY (item->width != -1 && item->height != -1)) return; was intended.
Created attachment 5421 Don't check item->width twice Indeed there's no need to check item->width twice on the same line. Checking for item->height isn't needed because the function never uses item->height but does set it at the end.
Pushed to master in: commit 0afa544fd7e9ca3d589c4d2a9f0ef01a64f4816c Author: Eric Koegel <eric.koegel@gmail.com> Date: Mon Apr 7 12:30:10 2014 +0300 Don't check item->width twice (Bug 10534) There's no need to check item->width twice on the same line. Also checking for item->height isn't needed because the function never uses item->height but does set it at the end. http://git.xfce.org/apps/ristretto/commit/?id=0afa544fd7e9ca3d589c4d2a9f0ef01a64f4816c