! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
exo-icon-bar.c:1164: possible typo ?
Status:
RESOLVED: FIXED

Comments

Description David Binderman 2013-11-26 11:30:43 CET
I just put the source code of exo-0.10.2 through
the static analyser cppcheck. It said

[exo-icon-bar.c:1164] -> [exo-icon-bar.c:1164]: (style) Same expression on both sides of '&&'.

Source code is

  if (G_LIKELY (item->width != -1 && item->width != -1))
    return;

Maybe 

  if (G_LIKELY (item->width != -1 && item->height != -1))
    return;

would be better code.
Comment 1 Simon Steinbeiss editbugs 2015-02-17 00:13:56 CET
This indeed looks like a small bug in exo-icon-bar that still exists: http://git.xfce.org/xfce/exo/tree/exo/exo-icon-bar.c#n1164.

Note that exo's icon-bar isn't really used anymore anywhere nowadays. One of the last places was xfce4-power-manager as far as I know.
Comment 2 Sean Davis editbugs 2015-02-17 00:28:21 CET
Good catch, fix applied here: http://git.xfce.org/xfce/exo/commit/?id=3bf3c7f643713d3ed8ddd4030405b71dfa1148ba

Bug #10515

Reported by:
David Binderman
Reported on: 2013-11-26
Last modified on: 2015-02-17

People

Assignee:
Nick Schermer
CC List:
3 users

Version

Version:
unspecified

Attachments

Additional information