! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
desktop flickers white when xfdesktop starts
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Alistair Buxton 2013-11-25 20:59:52 CET
On restarting, there is a delay between xfdesktop drawing it's window, and the wallpaper being initialized, leading to the window being white for a while.

This is a regression, caused by the commit:
http://git.xfce.org/xfce/xfdesktop/commit/?id=9becad1569798894bdae9beaffc9076338fed299
Comment 1 Alistair Buxton 2013-11-25 23:38:10 CET
Created attachment 5241 
realize but don't show the window until background is drawn

Instead of immediately showing the desktop window upon create, realize it instead.

Then, actually show it only after the wallpaper has been drawn.

Possible problems:
* How does this react when the user has a solid/gradient wallpaper?
* gtk_widget_show() will get called a lot.
Comment 2 Eric Koegel editbugs 2013-11-26 02:49:16 CET
Thanks for the patch!

Pushed to master: http://git.xfce.org/xfce/xfdesktop/commit/?id=e47515567cecc02650e18ac1826fccc94da80857

* How does this react when the user has a solid/gradient wallpaper?
  It will work the same way. The only difference is that in xfce_backdrop_generate_async it will only generate the canvas and signal the backdrop is ready. Same thing happens if the pixbuf loader fails to load the file for whatever reason (like a bad/corrupt image). For reference:
http://git.xfce.org/xfce/xfdesktop/tree/src/xfce-backdrop.c?id=e47515567cecc02650e18ac1826fccc94da80857#n1492

* gtk_widget_show() will get called a lot.
  It shouldn't cause too much overhead especially since the icon's pixbufs get cached so redraws are quick.
Comment 3 Simon Steinbeiss editbugs 2013-11-26 12:29:05 CET
Fix pushed to master.

Bug #10513

Reported by:
Alistair Buxton
Reported on: 2013-11-25
Last modified on: 2013-11-26

People

Assignee:
Eric Koegel
CC List:
2 users

Version

Version:
Unspecified

Attachments

Additional information