! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Set as wallpaper doesnt work (xfdesktop-4.11)


Description Aaditya Bagga 2013-11-24 11:08:02 CET
Using xfdesktop-4.11 on Manjaro Linux.

On right clicking an image, set as wallpaper, doesnt change the wallpaper.

used to work before with xfdesktop-4.10
Comment 1 Aaditya Bagga 2013-11-24 11:08:59 CET
pacman -Q xfdesktop
xfdesktop 4.11.1-1
Comment 2 Aaditya Bagga 2013-11-24 11:23:50 CET
Have I filed it wrong?
Should it be filed with Thunar?
I do remember that xfdesktop was recently updated, but I dont remember when thunar was updated.

pacman -Q thunar
thunar 1.6.3-1
Comment 3 Aaditya Bagga 2013-11-25 06:40:02 CET
I had set the wallpaper yesterday.
Today when I restart my system -> new wallpaper applied!
Comment 4 Aaditya Bagga 2013-11-25 06:49:01 CET
I think that it works today is becuase I mistakenly downgraded my system last night and now xfdesktop is at 4.10

pacman -Q xfdesktop
xfdesktop 4.10.2-1
Comment 5 Eric Koegel editbugs 2013-11-26 08:24:43 CET
Created attachment 5242 
Update xfconf setting for thunar-wallpaper plugin

  This patch is for the wallpaper plugin in Thunar. Since xfdesktop changed how it sets the backdrop Thunar will have to be updated to set those fields as well.
  The only other way to have xfdesktop notice the old xfconf format would be to restart xfdesktop.
Comment 6 Eric Koegel editbugs 2013-11-26 08:25:38 CET
Moving to thunar-wallpaper plugin.
Comment 7 Aaditya Bagga 2014-04-18 10:49:51 CEST
Hi, was I supposed to apply it to thunar-wallpaper-plugin (http://archive.xfce.org/src/thunar-plugins/thunar-wallpaper-plugin/0.0/),

or to Thunar itself? (http://git.xfce.org/xfce/thunar/tree/plugins/thunar-wallpaper)

Anyway I applied it to Thunar-1.6.3 , like-

  # Apply thunar-wallpaper-plugin patch
  patch -p1 $srcdir/Thunar-1.6.3/plugins/thunar-wallpaper/twp-provider.c ./0001-Update-xfconf-setting-for-thunar-wallpaper-plugin.patch

But even with the patch, if I choose an image and select Set as wallpaper, it does not have any effect... (while I can change it via Desktop settings)
Comment 8 Eric Koegel editbugs 2014-06-01 10:09:23 CEST
Sorry it took me so long to get back to this, I missed the e-mail notification. Yes, this should apply against thunar (I don't know why there's a separation in bugzilla for it), if you've used git clone to get a copy of thunar's source then:

cd /path/to/thunar
# hop on a local branch for testing
git checkout -b wallpaper
# Apply patch
git am 0001-Update-xfconf-setting-for-thunar-wallpaper-plugin.patch
# make new version
make install

Now, the one catch is that thunar runs as a daemon in the background so you'll have to stop it first to see any changes, thunar -q will do that.

For what it's worth, this patch got cherry-picked in by the Xubuntu guys for the 14.04 release so it looks like it works :) https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/1277149 on their tracker for the details.
Comment 9 Eric Koegel editbugs 2014-06-01 10:12:10 CEST
*** Bug 10390 has been marked as a duplicate of this bug. ***
Comment 10 Aaditya Bagga 2014-06-01 11:26:11 CEST
Why yes, the patch seems to be working now :)
Perhaps I had forgotten to restart as you say, and never checked back.
Comment 11 Eric Koegel editbugs 2014-06-01 12:32:56 CEST
Glad the patch works for you as well! We should leave this open until someone commits this to Thunar so it doesn't get forgotten.
Comment 12 Jannis Pohlmann editbugs 2014-07-25 15:09:19 CEST
Pushed to master. Note the problem with "Apply to all workspaces", as described in the commit message below.

commit 766b1e3fc28dc3fd9e01420bdb4ec84e3d2fdfdb
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Tue Nov 26 10:16:21 2013 +0300

    Update xfconf setting for thunar-wallpaper plugin
    Xfdesktop uses a new xfconf format starting with version 4.11.
    This patch updates the thunar-wallpaper plugin to set the image
    in the new format while continuing to set the old format.
    Comment from Jannis: This currently only works if "Apply to all
    workspaces" is disabled in xfdesktop. We might have to set the
    workspace0 wallpaper as well in order for the wallpaper to be
    applied in this case.
Comment 13 Eric Koegel editbugs 2014-07-27 12:43:07 CEST
Good catch, opened a new report with a patch at https://bugzilla.xfce.org/show_bug.cgi?id=11047

Bug #10509

Reported by:
Aaditya Bagga
Reported on: 2013-11-24
Last modified on: 2014-07-27
Duplicates (1):
  • 10390 thunar-wallpaper-plugin: update xfconf key path for xfdesktop 4.11.x


Stephan Arts
CC List:
3 users




Additional information