! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add option to avoid action when NOT pressing Ctrl
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-clipman-plugin
Component:
General

Comments

Description carlosjosepita 2013-11-23 01:48:13 CET
The option to avoid showing the action menu when pressing Ctrl assumes that usually one wants the action to run or that the regexs are very selective. That's not always the case; for example, an action could search a word in a web dictionary, so the regex would be something like "[a-zA-Z]{3,}". I propose to replace the checkbox "Skip action by holding Control" for a dropdown "Skip action by" with two possible values "holding Control" and "not holding Control".
Comment 1 Mike Massonnet editbugs 2014-02-02 12:54:37 CET
hi,

git commit 547218e1f5710465d6fdb761c8d7cb96a81c9558

it's not tested, but should do it.

please confirm.

regards,
mike
Comment 2 Mike Massonnet editbugs 2014-05-28 12:44:58 CEST
released with 1.2.5
Comment 3 Joe B. 2014-07-15 22:59:33 CEST
Seems broken. Now I have to always hold control to trigger actions no matter the setting chosen.

Using Clipman 1.2.5 on Fedora 20 with latest updates.
Comment 4 Mike Massonnet editbugs 2014-07-16 08:33:12 CEST
works for me, but i noticed the actions will only popup once when selecting the same text content repeatedly.
Comment 5 Joe B. 2014-07-16 17:09:07 CEST
Yeah, I know about the only pop up once for the same text. Been that was as
long as I can remember. That's fine.

The problem may be tangential. I notice no matter what I set it to it always
reverts to "Skip actions by holding Control" but behaves the opposite. And
~/.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-panel.xml
always reverts to
<property name="skip-action-on-key-down" type="bool" value="false"/>
no matter how I set it. Even if I hand edit the .xml to "true" then run clipman
the value reverts to false.

For now I've just hacked the whole option out of the code. Ctrl was a bad
choice anyhow IMHO since Ctrl-double click has meaning to other programs.

Thanks for checking into it though.

Bug #10506

Reported by:
carlosjosepita
Reported on: 2013-11-23
Last modified on: 2014-07-16

People

Assignee:
Mike Massonnet
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information