! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
thunar-vfs-1.2.0/thunar-vfs/thunar-vfs-thumb-jpeg.c:427: possible bad if stat...
Status:
RESOLVED: WONTFIX
Product:
Thunar-thumbnailers
Component:
General

Comments

Description David Binderman 2013-11-19 23:11:12 CET
I just ran the static analyser over the source code
of thunar-vfs-1.2.0

It said

[thunar-vfs-thumb-jpeg.c:427] -> [thunar-vfs-thumb-jpeg.c:425]: (style) Duplicate conditions in 'if' and related 'else if'.

Source code is

          if (tag == 0x0100)
            exif->thumb.thumb_tiff.width = value;
          else if (tag == 0x0100)
            exif->thumb.thumb_tiff.height = value;

Suggest change 2nd if.
Comment 1 Robby Workman editbugs 2014-12-03 15:21:59 CET
It was indeed a bug, but an inconsequential one. More importantly, thunar-vfs is no longer maintained or part of xfce, so I'm closing this.

Bug #10503

Reported by:
David Binderman
Reported on: 2013-11-19
Last modified on: 2014-12-03

People

Assignee:
Erlend Davidson
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information