! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Compress files on desktop
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Naga44 2013-11-15 12:54:17 CET
Hi,

On the desktop, with a right click "Create an archive" doesn't appears, whereas it does on Thunar.

I think this is pretty basic and should be added.
Comment 1 Naga44 2013-11-19 17:14:40 CET
Or more precisely, not on folders. It does work on a single file...
Comment 2 Naga44 2013-11-19 17:18:31 CET
Created attachment 5238 
Créer une archive / Create an archive

In French (créer une archive / Create an archive), doesn't appears for folders.
Comment 3 Eric Koegel editbugs 2013-12-29 20:51:27 CET
Created attachment 5286 
Only use thunarx_menu_provider_get_file_actions

This patch should fix the issue. Basically it looks like xfdesktop only needs to call thunarx_menu_provider_get_file_actions for the thunar plugins to show up. If you can, please test it out.
Comment 4 Naga44 2013-12-30 12:21:53 CET
(In reply to Eric Koegel from comment #3)
> Created attachment 5286 
> Only use thunarx_menu_provider_get_file_actions
> 
> This patch should fix the issue. Basically it looks like xfdesktop only
> needs to call thunarx_menu_provider_get_file_actions for the thunar plugins
> to show up. If you can, please test it out.

Hi,

First, thank you for taking time to answer.

I am not a total noob, but I am not developper too ;)

From what I searched on the web, do I have to create a file named "thunar-2/thunarx/thunarx-menu-provider.c" in "/usr/include/" and to fill it up with :

xfdesktop_file_icon_manager_populate_context_menu(XfceDesktop *desktop,
             GList *menu_actions = NULL;
             ThunarxMenuProvider *provider;
 
-            if(g_file_info_get_file_type(info) == G_FILE_TYPE_DIRECTORY) {
-                for(l = fmanager->priv->thunarx_menu_providers; l; l = l->next) {
-                    provider = THUNARX_MENU_PROVIDER(l->data);
-                    menu_actions = g_list_concat(menu_actions,
-                                                 thunarx_menu_provider_get_folder_actions(provider,
-                                                                                          toplevel,
-                                                                                          THUNARX_FILE_INFO(file_icon)));
-                }
-            } else {
-                for(l = fmanager->priv->thunarx_menu_providers; l; l = l->next) {
-                    provider = THUNARX_MENU_PROVIDER(l->data);
-                    menu_actions = g_list_concat(menu_actions,
-                                                 thunarx_menu_provider_get_file_actions(provider,
-                                                                                        toplevel,
-                                                                                        selected));
-                }
+            /* thunar file specific actions (allows them to operate on folders
+             * as well) */
+            for(l = fmanager->priv->thunarx_menu_providers; l; l = l->next) {
+                provider = THUNARX_MENU_PROVIDER(l->data);
+                menu_actions = g_list_concat(menu_actions,
+                                             thunarx_menu_provider_get_file_actions(provider,
+                                                                                    toplevel,
+                                                                                    selected));
             }
-            
+
             if(menu_actions) {
                 xfdesktop_menu_shell_append_action_list(GTK_MENU_SHELL(menu),
                                                         menu_actions);
-- 

(PS : No such file or folder exist on my computer, I read file:///usr/share/gtk-doc/html/thunarx/ThunarxMenuProvider.html, but I don't understand much of it...)
Comment 5 Eric Koegel editbugs 2014-01-01 07:46:16 CET
Naga44,
  No, you'd have to apply the fix to xfdesktop's code and
then build it. http://docs.xfce.org/xfce/building covers
the process if you're interested. However I pushed the patch
to master in: http://git.xfce.org/xfce/xfdesktop/commit/?id=b13d47e52d3755f9e9c424339063370a8ca7234b
So you'll see the fix in the 4.12 release of xfce. Thanks
for reporting the issue!

Bug #10492

Reported by:
Naga44
Reported on: 2013-11-15
Last modified on: 2014-01-01

People

Assignee:
Eric Koegel
CC List:
1 user

Version

Version:
Unspecified

Attachments

Additional information