! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
XPM icons are not scale in menu item
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Olivier Duchateau 2013-11-02 21:15:01 CET
Created attachment 5221 
Scale XPM images

With the latest version (4.11.1) and previous (4.11.0, 4.10.2) XPM images are not scaled.

Patch (it's very dirty) fixes this issue.

I hard coded size of icons (22px), I don't know if it's right.
Comment 1 Eric Koegel editbugs 2013-11-03 07:31:48 CET
Thanks for the patch, here's a couple notes that might help:

- We can use xfdesktop_get_file_mimetype and do a g_strcmp0 to make it easier. It's in xfdesktop-common.h so that probably needs to be included.

- Instead of hard coding it to 22 can we check if it isn't the current w or h then scale it to that?

- If you want you can also submit it as a git patch rather than just a diff. Then you can add a commit message and get proper credit for your work!
Comment 2 Olivier Duchateau 2013-12-17 20:40:56 CET
Patch in bug #10545 fixes scaling of XPM icons.

Bug #10461

Reported by:
Olivier Duchateau
Reported on: 2013-11-02
Last modified on: 2013-12-17

People

Assignee:
Eric Koegel
CC List:
3 users

Version

Version:
Unspecified

Attachments

Scale XPM images (3.83 KB, application/octet-stream)
2013-11-02 21:15 CET , Olivier Duchateau
no flags

Additional information