Created attachment 5189
Minimize button disappear
When using JetBrains WebStorm (a java application), i open two projects in two different window, both of which have minimize buttons.
Then i calls commit which brings a modal dialog, the minimize button in the titlebar disappears and never returns until i restart the whole WebStorm.
But if only one WebStorm window exists, minimize button will be kept.
I google and find a similar issue: http://forum.xfce.org/viewtopic.php?id=6005
OK, i just found what happening.
When a modal window appeared, the whole window will be marked not XFWM_FLAG_HAS_HIDE, but when modal window disappeared, this process will not be undone.
In fact this process is not necessary since CLIENT_CAN_HIDE_WINDOW macro has already take care of it.
I attach a patch to delete to unnecessary unset process.
Created attachment 5256
Remove unnecessary unset
Are there any plans to fix this?
Sure, it just escaped the radar...
While I agree with the comment 2, I don't agree with the patch from attachment 5256 because if a window is a transient window, it should not have the hide button so the code is correct.
The problem is the app is setting a transient relationship on its toplevel window as well temporarily to maintain a given stacking order (which does not surprise me from a Java/Swing application).
So the right way to fix that is to restore the buttons when the transient property is removed.
I have a (slightly larger) patch for that.
Fix as been pushed to git master.