! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Modal dialog will eat the minimize button of child windows.


Description ayanamist 2013-10-18 07:56:49 CEST
Created attachment 5189 
Minimize button disappear

When using JetBrains WebStorm (a java application), i open two projects in two different window, both of which have minimize buttons.
Then i calls commit which brings a modal dialog, the minimize button in the titlebar disappears and never returns until i restart the whole WebStorm.
But if only one WebStorm window exists, minimize button will be kept.
I google and find a similar issue: http://forum.xfce.org/viewtopic.php?id=6005
Comment 1 ayanamist 2013-12-06 07:15:55 CET
OK, i just found what happening.
When a modal window appeared, the whole window will be marked not XFWM_FLAG_HAS_HIDE, but when modal window disappeared, this process will not be undone.
In fact this process is not necessary since CLIENT_CAN_HIDE_WINDOW macro has already take care of it.
I attach a patch to delete to unnecessary unset process.
Comment 2 ayanamist 2013-12-06 07:16:35 CET
Created attachment 5256 
Remove unnecessary unset
Comment 3 Max Khaberev 2015-11-24 11:19:08 CET
Are there any plans to fix this?
Comment 4 Olivier Fourdan editbugs 2015-11-25 10:31:19 CET
Sure, it just escaped the radar...
Comment 5 Olivier Fourdan editbugs 2015-11-26 11:38:24 CET
While I agree with the comment 2, I don't agree with the patch from attachment 5256  because if a window is a transient window, it should not have the hide button so the code is correct.

The problem is the app is setting a transient relationship on its toplevel window as well temporarily to maintain a given stacking order (which does not surprise me from a Java/Swing application).

So the right way to fix that is to restore the buttons when the transient property is removed.

I have a (slightly larger) patch for that.
Comment 6 Olivier Fourdan editbugs 2015-11-26 11:43:09 CET
Fix as been pushed to git master.

Bug #10413

Reported by:
Reported on: 2013-10-18
Last modified on: 2015-11-26


Olivier Fourdan
CC List:
2 users




Minimize button disappear (324.90 KB, image/png)
2013-10-18 07:56 CEST , ayanamist
no flags
Remove unnecessary unset (562 bytes, patch)
2013-12-06 07:16 CET , ayanamist
no flags

Additional information