! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Assigning the same Application Shortcut twice deletes it.
Status:
RESOLVED: MOVED
Product:
Xfce4-settings
Component:
Keyboard Settings

Comments

Description jay.strict 2013-10-14 01:51:38 CEST
Start xfce4-keyboard-settings -> Application Shortcuts.
Add a new Shortcut Command, like "true".
Assign an arbitrary shortcut to this command, like "Ctrl+A".
Double-click on the shortcut and try to assign "Ctrl+A" again.

Result: The entire Shortcut Command gets deleted from the list.
Comment 1 jay.strict 2013-10-22 19:04:16 CEST
Created attachment 5194 
Patch for xfce4-settings-4.10.0

Attached a proposed patch.
I think it is sane to remove the call of xfce_shortcuts_provider_reset_shortcut() from xfce_keyboard_settings_validate_shortcut(), because the validation function should not modify any shortcut, just check whether it's ok.
Please comment.
Comment 2 jay.strict 2013-10-29 11:07:10 CET
Please, could somebody comment?
Comment 3 Jérôme Guelfucci editbugs 2013-10-29 21:22:07 CET
Hello,

This looks like a duplicate of bug #8749 which was fixed in libxfce4ui 4.11 (http://git.xfce.org/xfce/libxfce4ui/commit/?id=2ef1c9713fdbf6a27a3c90544dc1c5ed52d75fa5). We still need to release a 4.10.x version with the backported fix.

Cheers,

Jérôme
Comment 4 Git Bot editbugs 2020-05-28 22:57:20 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-settings/-/issues/29.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #10406

Reported by:
jay.strict
Reported on: 2013-10-14
Last modified on: 2020-05-28

People

Assignee:
Jérôme Guelfucci
CC List:
3 users

Version

Version:
4.10.0

Attachments

Patch for xfce4-settings-4.10.0 (2.10 KB, patch)
2013-10-22 19:04 CEST , jay.strict
no flags

Additional information