Hi, in the 4.11.0 xfdesktop4 release, the xfconf property scheme for storing the wallpaper path has changed. In 4.10 it was: /backdrop/screenX/monitorX/image-path In 4.11 it's now: /backdrop/screenX/monitorXXXXX/workspaceX/image-style with monitorXXXXX being the monitor *name* (LVDS1 in my case) and not monitor number. That means we lose the background setting when upgrading, and also means it's not longer possible to preseed the setting since we don't know in advance the monitor name.
Created attachment 5168 Migrate backdrop settings Good point! This proposed patch hopefully will help solve both issues. With it, Xfdesktop will search for backdrop settings in the new location, then the old location, and finally fall back to the DEFAULT_BACKDROP. This way you can still preseed new installs using the old format (except for the image style 'Auto' which has no conversion). Let me know if this is acceptable. Thanks!
Looks good at first sight, but it doesn't apply against 4.11 or HEAD so I can't really test.
Applies fine to 4.11.0 release here. Now xfdesktop-settings list all images from my ~/Images folder, but I can't applied one anyone. An I can't select an image manually (images are grayed). ~ xfconf-query -c xfce4-desktop -l /backdrop/screen0/monitor0/image-path /backdrop/screen0/monitor0/image-show /backdrop/screen0/monitor0/image-style /backdrop/screen0/monitor0/last-image /backdrop/screen0/monitor0/last-single-image /backdrop/screen0/monitor1/image-path /backdrop/screen0/monitor1/last-image /backdrop/screen0/monitor1/last-single-image /backdrop/screen0/monitorLVDS/workspace0/image-style /backdrop/screen0/monitorLVDS/workspace0/last-image /backdrop/screen0/monitorLVDS/workspace-1/backdrop-cycle-enable /backdrop/screen0/monitorLVDS/workspace-1/image-style /backdrop/screen0/monitorLVDS/workspace-1/last-image If I set backdrop via xfconf-query -c xfce4-desktop -p /backdrop/screen0/monitorLVDS/workspace0/last-image -s /path/to/image.jpg, it works Note: same behavior on a new user with a blank xfconf configuration Note2: default backdrop (xfce-blue.jpg) is Scaled , I think it's not the best behavior :)
Created attachment 5173 Migrate backdrop settings This fixes the issues you brought up in here as well as on IRC. Please let me know if you run into issues with this patch.
Well, doesn't work either. But xfdesktop-git works great, and xfdesktop 4.11 + http://git.xfce.org/xfce/xfdesktop/commit/?id=54090ec7c836ea6e0d3484ac4afd2850e70a4f2c works too !
(In reply to Skunnyk from comment #5) > Well, doesn't work either. > But xfdesktop-git works great, and xfdesktop 4.11 + > http://git.xfce.org/xfce/xfdesktop/commit/ > ?id=54090ec7c836ea6e0d3484ac4afd2850e70a4f2c works too ! That commit looks completely unrelated, doesn't it?
(In reply to Eric Koegel from comment #4) > Created attachment 5173 > Migrate backdrop settings > > This fixes the issues you brought up in here as well as on IRC. Please let > me know if you run into issues with this patch. Hmmh, the patch applies fine, but the background is still wrong (actually, no background is set). And even worse, even when selecting a background in desktop settings, it doesn't appear, even though the xfconf property is correct.
Created attachment 5183 Migrate backdrop settings from previous versions Third times the charm? Under the right conditions xfdesktop-settings can get stuck thinking the workspace number is -1. That's been corrected (hopefully). Also since this patch adds to the xfce-backdrop enums, you might have to call 'make clean' before building with this patch or make won't auto-generate new xfce-desktop-enum-types files and that means xfdesktop's backdrop class won't be able to use the properties (gtk throws out error messages in the logs). That might explain the previous patches not changing the wallpaper when a new one is selected. There's also a couple other small changes like using exo_gdk_pixbuf_new_from_file_at_max_size to avoid scaling on every single thumbnail loaded in the settings app. Let me know if this does correct those issues and allow for a smoother transition to the new settings format.
(In reply to Eric Koegel from comment #8) > Created attachment 5183 > Migrate backdrop settings from previous versions > > Third times the charm? Sorry to bother you again, but it (again) doesn't seem to apply against 4.11.0.
No worries. The release tarball doesn't contain everything needed, but it does have enough. To get it to work I went into the xfdesktop-4.11.0 folder and ran: wget "https://bugzilla.xfce.org/attachment.cgi?id=5183" --output-document=10380.patch patch -p1 < 10380.patch Next I ran: ./configure --enable-maintainer-mode && make Make will fail because the xfdesktop-file-manager-dbus.xml isn't included in the dev release, however it did GEN xfce-desktop-enum-types.c which is what we need. After that it is back to the normal ./configure && make When applying against HEAD it gets easier since you can create a quick branch, use git am to apply the patch and ./autogen.sh && make will do everything.
(In reply to Eric Koegel from comment #10) > No worries. The release tarball doesn't contain everything needed, but it > does have enough. > To get it to work I went into the xfdesktop-4.11.0 folder and ran: > wget "https://bugzilla.xfce.org/attachment.cgi?id=5183" > --output-document=10380.patch > patch -p1 < 10380.patch > > Next I ran: ./configure --enable-maintainer-mode && make > Make will fail because the xfdesktop-file-manager-dbus.xml isn't included in > the dev release, however it did GEN xfce-desktop-enum-types.c which is what > we need. > After that it is back to the normal ./configure && make > > When applying against HEAD it gets easier since you can create a quick > branch, use git am to apply the patch and ./autogen.sh && make will do > everything. I've tried to apply against 4.11.0 tag and it seems to work fine, the background is correctly set.
Thanks for testing it out. I've pushed it to master: http://git.xfce.org/xfce/xfdesktop/commit/?id=af240b063cd0678dc1739ffa28e93f1ff530bead
Thanks. Any idea when 4.11.1 will be released?
I've tried 4.11.0 + af240b063cd0678dc, but now it never applies the backdrops. I'm using compiz though, not xfwm4, but the older version worked fine; so does 4.11.0 without that patch except the one-time failure to recognize the proper workspaces. BTW: It would be great if xfdesktop would support virtual desktops too (workspaces in xfwm4 == virtual desktops in compiz). There is a wallpaper plugin for compiz, but I prefer the xfce one.
No new issues reported with this bug. I'm marking it as resolved. Harald, the virtual desktop issue is a separate issue and has been reported in this bug: https://bugzilla.xfce.org/show_bug.cgi?id=9451