! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[patch] unlock mutex in connect instead of connect_thread
Status:
RESOLVED: FIXED

Comments

Description Mike Massonnet editbugs 2013-09-25 17:58:31 CEST
Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/xfce4/xfmpc/Makefile,v
retrieving revision 1.19
diff -u -p -u -r1.19 Makefile
--- Makefile	31 May 2013 15:35:24 -0000	1.19
+++ Makefile	24 Sep 2013 16:17:13 -0000
@@ -4,7 +4,7 @@ COMMENT=	Xfce4 Music Player Daemon clien
 
 XFCE_VERSION=	0.2.2
 XFCE_GOODIE=	xfmpc
-REVISION =	2
+REVISION =	3
 
 # GPLv2
 PERMIT_PACKAGE_CDROM=	Yes
Index: patches/patch-src_mpdclient_c
===================================================================
RCS file: patches/patch-src_mpdclient_c
diff -N patches/patch-src_mpdclient_c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_mpdclient_c	24 Sep 2013 16:17:13 -0000
@@ -0,0 +1,24 @@
+$OpenBSD$
+
+Do not try to unlock an unlocked mutex.
+
+--- src/mpdclient.c.orig	Tue Sep 24 18:13:38 2013
++++ src/mpdclient.c	Tue Sep 24 18:14:58 2013
+@@ -389,8 +389,6 @@ xfmpc_mpdclient_connect_thread (XfmpcMpdclient *mpdcli
+ 
+   priv->connecting = FALSE;
+ 
+-  g_mutex_unlock (priv->mutex);
+-
+   return NULL;
+ }
+ 
+@@ -426,6 +424,8 @@ xfmpc_mpdclient_connect (XfmpcMpdclient *mpdclient)
+   g_thread_join (thread);
+ 
+   g_signal_emit (mpdclient, signals[SIG_CONNECTED], 0);
++
++  g_mutex_unlock (priv->mutex);
+ 
+   return TRUE;
+ }
Comment 1 Landry Breuil editbugs 2016-06-29 22:21:51 CEST
Commited in 40ab9d4

Bug #10366

Reported by:
Mike Massonnet
Reported on: 2013-09-25
Last modified on: 2016-06-29

People

Assignee:
Vincent Legout
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information