! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce's xinitrc calls xrdb -merge with -nocpp
Status:
RESOLVED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description erik 2013-09-05 14:05:26 CEST
Hi Guys,

as it has been pointed out already [1], xfce4's xinitrc runs xrdb -merge on the user's Xresources file using the -nocpp option. While I can certainly understand the benefit of using -nocpp for well-defined system-wide resources, doing so on a user's Xresources file (which in fact often contains cpp preprocessor directives) results in undefined behaviour and breaks compatibility with other desktops environments. Instead, I would prefer to have either the -nocpp option or the xrdb call removed completely. The latter will simply result in the correct behavior on most distributions since there the user's Xresources are already (correctly) loaded without -nocpp by a system-wide xsession.d-snippet.

cheers,

  erik


[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=648553
Comment 1 Justin Brewer 2015-03-13 23:38:30 CET
Created attachment 6078 
Drop -nocpp flag
Comment 2 Justin Brewer 2015-03-13 23:51:53 CET
I'm surprised this isn't a more discussed issue. Anyone who uses XFCE and has preprocessor directives in their .Xresources file should run into this. As noted above, there was a long winded discussion at Debian about this, but it went off on a tangent about shaving a few microseconds off startup time and died out. It was eventually marked as fixed there, so I guess they patch it themselves?

Regardless, Archlinux ships this script vanilla, and patching it by hand every time the package gets updated is starting to get old.
Comment 3 erik 2015-03-18 14:34:29 CET
Hi Justin,

like you pointed out, the behaviour has been finally fixed in Debian right after I've bumped it again. Here's the according commit:

http://anonscm.debian.org/viewvc/pkg-xfce/desktop/trunk/xfce4-session/debian/patches/01_fix-xrdb-call.patch?view=markup&pathrev=7968

erik
Comment 4 Eric Koegel editbugs 2015-03-28 05:09:35 CET
Thanks! Pushed to master in:
commit 2b12a2365ec2677c9642c670c5bb4046efb54299
Author: Justin Brewer <jzb0012@auburn.edu>
Date:   Fri Mar 13 17:59:26 2015 -0400

    Drop -nocpp option from call to xrdb
    
    Users' .Xresources files often contain preprocessor directives, so disabling the
    preprocessor breaks the behavior of these files.
    
    Signed-off-by: Eric Koegel <eric.koegel@gmail.com>
http://git.xfce.org/xfce/xfce4-session/commit/?id=83fd4fee8697fc5da8411c99b18900d211b72d68

Bug #10334

Reported by:
erik
Reported on: 2013-09-05
Last modified on: 2015-03-28

People

Assignee:
Xfce Bug Triage
CC List:
5 users

Version

Version:
Unspecified

Attachments

Drop -nocpp flag (1007 bytes, patch)
2015-03-13 23:38 CET , Justin Brewer
no flags

Additional information