! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Terminal borders in Drop down mode
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Jim 2013-08-13 02:56:45 CEST
With xfce4-terminal in drop down mode there are borders visible however if it is started without the drop down option the borders aren't visible. Preferences has the 'show borders' option not selected.

Fedora 19, Xfce 4.10 xfce4-terminal 0.6.2. The setting of Appearance, style theme etc. doesn't seem to have any affect.

To reproduce, start terminal with or without --drop-down option. Go to Preferences - Appearance, unselect Display Borders around new windows. (Menubar and Toolbar were also not selected and in Drop Down mode Scrollbar was not selected)
Close and re run terminal. Borders not visible unless --drop-down option was specified.
Comment 1 ToZ editbugs 2013-08-13 03:19:12 CEST
Am noticing the same in Arch with Xfce 4.10 and xfce4-terminal 0.6.2.
Comment 2 Shiv 2014-04-22 10:05:22 CEST
Created attachment 5448 
Screenshot

I can confirm this bug still exists in Xubuntu 14.04 and Xfce 4.10

The attached screenshot should make things clearer - the actual drop-down window has a border, but all other terminal windows do not.
Comment 3 ToZ editbugs 2015-05-27 15:22:13 CEST
Created attachment 6286 
Patch - remove borders from dropdown

Patch added to remove borders from notebook widget.
Comment 4 Viktor 2016-04-29 11:31:41 CEST
The white border is still there (xubuntu 16.04, xfce 4.12, xfce4-terminal 0.6.3).

There is a typo in the patch by ToZ (thinkess instead of thickness).
Comment 6 felix 2017-01-13 13:09:58 CET
Excuse me, that 'fix' is nonsense. It makes this completely useless border controlled by the same setting that is used to determine whether non-drop-down terminal windows should have *window manager decorations*. There's now no way to disable one without disabling the other. Just because you decided to call the latter 'borders' doesn't mean they are the same thing, FFS.

There was a much more sensible patch submitted in this very bug ticket, why didn't you apply that instead?
Comment 7 Igor editbugs 2017-01-13 16:37:16 CET
(In reply to felix from comment #6)
> Excuse me, that 'fix' is nonsense. It makes this completely useless border
> controlled by the same setting that is used to determine whether
> non-drop-down terminal windows should have *window manager decorations*.
> There's now no way to disable one without disabling the other. Just because
> you decided to call the latter 'borders' doesn't mean they are the same
> thing, FFS.
>
> There was a much more sensible patch submitted in this very bug ticket, why
> didn't you apply that instead?

Well, I didn't want to force disable the borders and wanted to make it configurable, just like in a normal mode.
But I think you're right that drop-down mode should have its own setting for that, so I will add it.

Bug #10297

Reported by:
Jim
Reported on: 2013-08-13
Last modified on: 2017-01-13

People

CC List:
6 users

Version

Attachments

Screenshot (421.19 KB, image/png)
2014-04-22 10:05 CEST , Shiv
no flags
Patch - remove borders from dropdown (838 bytes, patch)
2015-05-27 15:22 CEST , ToZ
no flags

Additional information