! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Newest vsync patch doesn't compile due to missing 'stropts.h' on Fedora 17
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
major
Product:
Xfwm4
Component:
General

Comments

Description Jonas Kulla 2013-07-11 20:51:59 CEST 
Commit 22d6df280117fba8eb7584bca631d73a7ba359e2 added optional vsync support to xfwm4, but the header 'stropts.h' included in compositor.c besides the other libdrm related ones. Apparently it's related to something called "STREAMS" that isn't even supported on Linux (https://bugzilla.redhat.com/show_bug.cgi?id=656245).

Anyway, commenting out the include made xfwm4 compile just fine, so I'm wondering if it's really necessary?
Comment 1 Eric Koegel editbugs 2014-07-06 08:17:53 CEST 
Created attachment 5539 
stropts.h doesn't exist on several platforms

This patch switches it over to using sys/ioctl.h to supply the ioctl function which should fix compilation issues on OpenBSD, FreeBSD, Fedora, and possibly others.

http://li604-44.members.linode.com/job/xfwm4/label=FreeBSD/lastBuild/console
http://li604-44.members.linode.com/job/xfwm4/label=OpenBSD/lastBuild/console
Are the failing builds on Free/Open BSD.
Comment 2 Simon Steinbeiss editbugs 2014-07-26 21:30:28 CEST 
Is this problem addressed/fixed in git master here?
http://git.xfce.org/xfce/xfwm4/commit/?id=f620c4539036981cc2393d9a1421f937d8f067c6
Comment 3 Eric Koegel editbugs 2014-07-27 16:15:07 CEST 
Yes. Marking resolved.

Bug #10237

Reported by:
Jonas Kulla
Reported on: 2013-07-11
Last modified on: 2014-07-27

People

Assignee:
Olivier Fourdan
CC List:
4 users

Version

Version:
unspecified
Target Milestone:
Xfce 4.6

Attachments

stropts.h doesn't exist on several platforms (1.50 KB, patch)
2014-07-06 08:17 CEST , Eric Koegel 		no flags

Additional information