! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add another GtkMessageType (GTK_MESSAGE_WARNING) under FreeBSD


Description Olivier Duchateau 2013-06-03 21:34:17 CEST
Created attachment 5053 
Add another GtkMessageType (GTK_MESSAGE_WARNING) under FreeBSD

Under FreeBSD, we don't have helper to install additional GStreamer plugins. That's why in GtkMessageDialog, "Install" button fails.

Patch displays GTK_MESSAGE_WARNING (users informed that plugin is missing).

Tested successfully with 0.4.0, 0.5.0 and 0.5.1
Comment 1 Sean Davis editbugs 2013-06-04 01:23:26 CEST
This is a great patch!  I have incorporated it into git master.  Thank you!
Comment 2 Olivier Duchateau 2013-06-04 19:26:07 CEST
(In reply to comment #1)
> This is a great patch!  I have incorporated it into git master.  Thank you!

Comment 3 Yves-Alexis Perez editbugs 2013-10-28 15:04:23 CET
Does this mean *noone* can provide helpers under FreeBSD?

The patch looks wrong by itself, it breaks build on anything !linux or !freebsd, and even there, if someone running a FreeBSD kernel did manually set helpers for gstreamer, he won't be able to use them.

Using __freebsd__ looks wrong to me here. The perfect way would be to be able to ask gstreamer if it had configured helpers available, but I don't know if there's a way to do that.

Another way would be to just use a compile-time option, so people having gstreamer installed (or distro maintainers) could select the one fitting their system.

Bug #10142

Reported by:
Olivier Duchateau
Reported on: 2013-06-03
Last modified on: 2013-10-28


Simon Steinbeiss
CC List:
2 users




Add another GtkMessageType (GTK_MESSAGE_WARNING) under FreeBSD (1.96 KB, application/octet-stream)
2013-06-03 21:34 CEST , Olivier Duchateau
no flags

Additional information