! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
PATCH: Add gamma correction and brightness slider to xfce4-display-settings
Status:
RESOLVED: MOVED
Product:
Xfce4-settings
Component:
Display Settings

Comments

Description Andreas Lampersperger 2013-05-07 15:14:37 CEST
Created attachment 5026 
Patch against xfce4-settings from git May 6 2013

The attached patch agains git version from May 6 2013 will add sliders 
for gamma correction and brightness to xfce4-display-settings.
(I remember that in once in old days, xfce had allready settings for gamma correction)

I would be pleased if you accept this patch or if you just write
me how to modify it in such a way, that you would accept it.

I've also attached a screenshot of the xfce4-display-settings dialog.
Comment 1 Andreas Lampersperger 2013-05-07 15:16:00 CEST
Created attachment 5027 
Screenshot of xfce4-display-settings
Comment 2 Nick Schermer editbugs 2013-05-07 17:41:16 CEST
Personally (but I'm not the guy maintaining this part of the settings), not relevant to include. If we want to have proper coloring support, colord is the way to go.
Comment 3 Simon Steinbeiss editbugs 2014-11-03 12:42:20 CET
*** Bug 6512 has been marked as a duplicate of this bug. ***
Comment 4 Simon Steinbeiss editbugs 2015-01-31 13:46:07 CET
As Nick pointed out, colord is the proper way to address this (even though it's a lot more complicated than your patch). The main problem I see is that it totally clutters the dialog and it's only useful in very rare cases.
Comment 5 Simon Steinbeiss editbugs 2017-02-14 23:52:15 CET
For what it's worth, I've rebased your patch on top of master and integrated it in the display settings dialog in a way that isn't as visually intrusive as the original patch.

You can check this branch for the working (but maybe not final) version:
https://git.xfce.org/users/ochosi/xfce4-settings/?h=improve_display_dialog
Comment 6 Simon Steinbeiss editbugs 2020-05-28 00:11:43 CEST
*** Bug 16303 has been marked as a duplicate of this bug. ***
Comment 7 Git Bot editbugs 2020-05-28 22:56:18 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-settings/-/issues/21.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #10069

Reported by:
Andreas Lampersperger
Reported on: 2013-05-07
Last modified on: 2020-05-28
Duplicates (2):
  • 6512 Add sliders to configure gamma correction
  • 16303 Adding a gamma option to xfconf

People

Assignee:
Jérôme Guelfucci
CC List:
6 users

Version

Version:
unspecified

Attachments

Patch against xfce4-settings from git May 6 2013 (53.52 KB, patch)
2013-05-07 15:14 CEST , Andreas Lampersperger
no flags
Screenshot of xfce4-display-settings (40.44 KB, image/png)
2013-05-07 15:16 CEST , Andreas Lampersperger
no flags

Additional information