! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
fails to build with automake-1.13 (should use AC_CONFIG_HEADERS instead of AM...
Status:
RESOLVED: FIXED

Comments

Description Samuli Suominen 2013-04-29 09:12:58 CEST
configure.in.in should use AC_CONFIG_HEADERS instead of AM_CONFIG_HEADER or otherwise the build will fail like:

aclocal-1.13: warning: autoconf input should be named 'configure.ac', not 'configure.in'
configure.in:17: error: 'AM_CONFIG_HEADER': this macro is obsolete.
    You should use the 'AC_CONFIG_HEADERS' macro instead.
/usr/share/aclocal-1.13/obsolete-err.m4:12: AM_CONFIG_HEADER is expanded from...
configure.in:17: the top level
autom4te-2.69: /usr/bin/m4 failed with exit status: 1
aclocal-1.13: error: echo failed with exit status: 1

it's a simple search and replace job...
sed -i -e 's:AM_CONFIG_HEADER:AC_CONFIG_HEADERS:' configure*
Comment 1 David Mohr 2013-05-03 07:27:15 CEST
Well, do you have a patch? My 1.11.6 automake doesn't know AC_CONFIG_HEADERS... 

Google found http://lists.gnu.org/archive/html/automake/2009-08/msg00040.html , which basically says it is a mess to check for automake version prior to 1.12.
Comment 2 David Mohr 2013-05-03 18:20:19 CEST
*** Bug 10056 has been marked as a duplicate of this bug. ***
Comment 3 Samuli Suominen 2013-05-03 19:03:12 CEST
(In reply to comment #1)
> Well, do you have a patch? My 1.11.6 automake doesn't know
> AC_CONFIG_HEADERS... 
> 
> Google found
> http://lists.gnu.org/archive/html/automake/2009-08/msg00040.html , which
> basically says it is a mess to check for automake version prior to 1.12.

AC_CONFIG_HEADERS has been around at least since 1.9, see:

/usr/bin/automake-1.11:      elsif ($macro eq 'AC_CONFIG_HEADERS')
/usr/bin/automake-1.12:      elsif ($macro eq 'AC_CONFIG_HEADERS')
/usr/bin/automake-1.13:      elsif ($macro eq 'AC_CONFIG_HEADERS')
/usr/bin/automake-1.9:      elsif ($macro eq 'AC_CONFIG_HEADERS')

Do you really need a patch to replace one word?
Comment 4 David Mohr 2013-05-03 19:14:34 CEST
(In reply to comment #3)
> AC_CONFIG_HEADERS has been around at least since 1.9, see:
> 
> /usr/bin/automake-1.11:      elsif ($macro eq 'AC_CONFIG_HEADERS')
> /usr/bin/automake-1.12:      elsif ($macro eq 'AC_CONFIG_HEADERS')
> /usr/bin/automake-1.13:      elsif ($macro eq 'AC_CONFIG_HEADERS')
> /usr/bin/automake-1.9:      elsif ($macro eq 'AC_CONFIG_HEADERS')
> 
> Do you really need a patch to replace one word?

No of course not.

Hm. I do wonder why automake failed then on my Debian system. Seems like I'll have to try again.
Comment 5 David Mohr 2013-05-05 03:33:03 CEST
Ok, it must've been a typo, now it works fine. Thanks Samuli!

[master f04d2cb] Bugfix: Use AC_CONFIG_HEADERS
Comment 6 David Mohr 2013-05-05 03:34:57 CEST
Ehm, commit id is 026edbbdac10d7c7d960f23b59af26f8f26184e5 after the rebase...

Bug #10044

Reported by:
Samuli Suominen
Reported on: 2013-04-29
Last modified on: 2013-05-05
Duplicates (1):
  • 10056 [xfburn] build with latest automake

People

Assignee:
Xfburn Bug Triage
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information