I have in my theme border-width = 1.0 and border-width-hover = 1.0, but border is only drawn when notification is hovered by mouse. Same effect with ZOMG-PONIES! theme for example. This is a major flaw as I see it. This didn't happen with xfce4-notifyd-0.2.2.
Created attachment 5010 xfce4-notifyd-0.2.3-restore-default-border.patch Hmm, it's coming back to me now. There were no borders for unhovered notifications in 0.2.2 either, but there was a related bug report: https://bugzilla.xfce.org/show_bug.cgi?id=5926 I'd added a patch there which is partially in 0.2.3 now, thank you. But one thing is missing, that actually draws border when popup is unhovered. Please, see the attached patch.
Hello, Thanks for reporting and fixing the bug at the same time. I had forgotten that there was a different code path when compositing is off and I run compositing all the time... I'll make sure I test with compositing off before releasing next time... Re your patch in the other bug report, I can't remember why I did not apply it directly and ended up mis-reinventing the wheel. Anyway, I'll wait until next weekend to see if there are any other immediate bugs to fix in 0.2.3 and release 0.2.4. Cheers, Jérôme
Thank you! Glad to hear that.