! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Custom bar colours are not used
Status:
CLOSED: FIXED
Product:
Xfce4-netload-plugin
Component:
General

Comments

Description Miguel Guedes 2012-07-02 09:23:04 CEST
Created attachment 4534 
Re-enable custom colours for progress bars

When using progress bars to display network activity and using custom colours, these are ignored with the default colours always being used instead.

Attached patch that fixes this.

Latest git version is affected.
Comment 1 Mike Massonnet editbugs 2012-07-10 16:26:24 CEST
Hi Miguel,

I can't reproduce :(

I tried to switch between different modes, the colors are kept in.

Please reopen and provide steps to reproduce the issue.

Regards,
Mike
Comment 2 Miguel Guedes 2012-07-10 20:19:52 CEST
Hi Mike

> I can't reproduce :(
>

Did you try cloning the latest GIT revision? The stable version is fine; it's just the latest commit that has this minor bug.

> I tried to switch between different modes, the colors are kept in.
>
> Please reopen and provide steps to reproduce the issue.

Here's a screenshot showing a build of the latest GIT commit (left) vs fixed (right) 
http://en.zimagez.com/zimage/netloadgitvsgit-fixed.php

Configuration box: shows that custom colours have been selected but they're not in use.
http://www.zimagez.com/zimage/screenshot-100712-191312.php

Panel items: shows only the two different versions of the plugins used.
http://www.zimagez.com/zimage/screenshot-100712-191218.php
Comment 3 Mike Massonnet editbugs 2012-07-10 20:46:34 CEST
Ok, I "thought" it was working, but I didn't try to change the colors, indeed it's broken, thanks for clarifying.
Comment 4 Mike Massonnet editbugs 2012-07-14 18:43:24 CEST
Fixed in git.

http://git.xfce.org/panel-plugins/xfce4-netload-plugin/commit/?id=7434a7f1fbb4c35c92add675d5a0314cacda8671

Thanks for your patches.

Regards,
Mike

Bug #9073

Reported by:
Miguel Guedes
Reported on: 2012-07-02
Last modified on: 2012-07-15

People

Assignee:
Mike Massonnet
CC List:
1 user

Version

Attachments

Additional information