! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xinitrc tries to delete $HOME when migrating Desktop
Status:
RESOLVED: FIXED
Product:
Xfce-utils
Component:
General

Comments

Description Mark Trompell 2011-11-15 08:32:04 CET
Created attachment 3960 
proposed untested patch

When $XDG_DESKTOP_HOME is set to $HOME (which is allowed in the spec in case you don't want a Desktop folder at all) xinitrc tries to delete $HOME when migrating Desktop. Fortunately rmdir fails because $Home is not empty.
probably it should check for $HOME" != "$XDG_DESKTOP_DIR before migrating the desktop.
Comment 1 Mark Trompell 2011-11-15 08:33:56 CET
Add Christian, so he doesn't add another bug
Comment 2 Christian Dywan 2011-11-15 11:24:30 CET
You beat me to it. The patch looks correct to me.

Here's the somewhat scary error log for reference, translated rmdir/ mv output:

/etc/gdm/Xsession: Beginning session setup...
/usr/bin/startxfce4: X server already running on display :0
Migrating /home/mechtilde/Desktop to /home/mechtilde/...
rmdir: failed to remove "/home/mechtilde/": No permission
mv: "/home/mechtilde/Desktop" and "/home/mechtilde/Desktop" are the same file
Desktop migration failed
ssh-agent is already running
xfdesktop[2340]: starting up
Comment 3 Mark Trompell 2011-11-15 11:47:35 CET
Created attachment 3962 
same goes for TEMPLATES

still untested
Comment 4 Nick Schermer editbugs 2011-11-17 21:36:26 CET
Fixed in master and 4.8.
Comment 5 Nick Schermer editbugs 2011-11-17 21:37:49 CET
And also in xfce4-session, which is the new location of the script.
Comment 6 Jerome 2012-03-14 11:12:09 CET
Hi.

I don't see the file in xfce4-session, and the change does not seem to appear on http://git.xfce.org/xfce/xfce-utils/tree/scripts/xinitrc.in.in?id=xfce-utils-4.8.3

The bug is still there on my up to date Debian Wheezy (versions 4.8.3 of both xfce4-utils and xfce4-session) : /etc/xdg/xfce4/xinitrc does not have the patch applied, and I get the error message in ~/.xsession-errors

It is not really a problem, but I thought it might be worth telling you.

Bug #8154

Reported by:
Mark Trompell
Reported on: 2011-11-15
Last modified on: 2012-03-14

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Attachments

proposed untested patch (640 bytes, application/octet-stream)
2011-11-15 08:32 CET , Mark Trompell
no flags
same goes for TEMPLATES (1.10 KB, patch)
2011-11-15 11:47 CET , Mark Trompell
no flags

Additional information