! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Font of the "Open with" dialog too thin - "Extralight"
Status:
RESOLVED: FIXED

Comments

Description Adam Purkrt 2011-06-03 17:32:29 CEST
Created attachment 3711 
window-shot of the open with dialog (with too thin a font)

The font of the "Open with" dialog is too "thin" - I think it's the "Extralight" version. The "book" version would be imo better.
Comment 1 Jannis Pohlmann editbugs 2011-06-03 17:41:39 CEST
We use the default Pango font weight for normal items, which is 400 or PANGO_WEIGHT_NORMAL. We only change this for headers like "Recommended Applications" and "Other Applications" where it is set to semi-bold.

This could be a theming issue where the default weight of GtkCellRendererText is set to something else than 400 but it's not an issue in Thunar.

I'm marking this one as closed as long as there is no good reason for assuming the bug might be in Thunar and not in your GTK+ theme or .gtkrc-2.0.
Comment 2 Adam Purkrt 2011-06-03 18:09:22 CEST
Thanks for the quick reply, Jannis.

Well I reported because the "Open with" dialog is the only place where I ever encountered this (imo) "weird", too thin a font.

It behaves the same in gentoo & ubuntu, and the only I'd say relevant change from default I did was enabling Full hinting in Settings/Appearance/Fonts.
Comment 3 Adam Purkrt 2011-06-03 18:37:46 CEST
Created attachment 3712 
this-is-imo-better
Comment 4 Jannis Pohlmann editbugs 2011-06-03 18:43:26 CEST
Which font and theme are you using? Did you try a different theme? I can try to reproduce it but I doubt the reason for this behavior is Thunar as it uses the default font weight of GtkCellRendererText.
Comment 5 Adam Purkrt 2011-06-03 18:49:31 CEST
Created attachment 3713 
it works fine after this change (patch against v1.2.2)
Comment 6 Adam Purkrt 2011-06-03 18:51:24 CEST
Seems to me like the weight wasn't set at all, it probably defaults to this "Extralight" style.

Anyway, the proposed patch solves the issue for me (see also the window-shot).
Comment 7 Jannis Pohlmann editbugs 2011-06-03 19:04:15 CEST
(In reply to comment #6)
> Seems to me like the weight wasn't set at all, it probably defaults to this
> "Extralight" style.

No, it defaults to 400 which is normal weight. And it should not matter anyway since we only set the "weight-set" property for header items in the tree view. This means that the weight should be default, no matter what "weight" says. 

So, there either is a bug in GTK+ OR your theme is broken. I'm asking again: what theme and font are you using to reproduce the bug?
Comment 8 Adam Purkrt 2011-06-03 19:28:45 CEST
Created attachment 3714 
font-dejavu-sans-bold-applist-still-extralight
Comment 9 Adam Purkrt 2011-06-03 19:29:59 CEST
> So, there either is a bug in GTK+ OR your theme is broken. I'm asking again:
> what theme and font are you using to reproduce the bug?

Settings/Appearance/Style is set to "Xfce"
Settings/Appearance/Fonts/Default Font is set to "Sans/Regular/10px" which is an alias of "Dejavu Sans/Book/10px" - it doesn't matter whether I select the alias or "Dejavu Sans/Book" specifically.

Basically, I'm using the default. Hope this answers your question.

As I have written, I don't see this "Extralight" style of font anywhere else in XFCE, and it is imo not very well readable. That's why I'm reporting.


Observation: I've now tried other fonts (than Dejavu Sans) and it works ok with them! But probably only because they doesn't have an "Extralight" version available. Unfortunatelly, I don't have other fonts that have "Extralight" style to test it (will try to find such a font).

Another observation: Even if I set the font to "Dejavu Sans/Bold/10px" (and not /Book), the application list is still in "Extralight" - see the window-shot
Comment 10 Jannis Pohlmann editbugs 2011-06-03 19:39:48 CEST
Ok, I can reproduce it now. That's really weird. BTW, your fix is ok but it is just a workaround that doesn't solve the real issue. I'll try to figure out what's going on there.
Comment 11 Adam Purkrt 2011-06-03 19:45:47 CEST
(In reply to comment #10)
> Ok, I can reproduce it now. That's really weird. BTW, your fix is ok but it is
> just a workaround that doesn't solve the real issue. I'll try to figure out
> what's going on there.

Good! Perhaps it really is a bug in the GTK+ after all. I don't use GTK+ much (or at all), just wanted to tweak things to make it work; I sense(d) that my patch is just a "dirty fix".

Best regards.
Comment 12 Adam Purkrt 2011-06-05 09:19:32 CEST
Created attachment 3718 
patch-no-2

This patch alone also solves the issue. Seems to me this is closer to the origin of the bug, but again I'm not at all a GTK+ veteran.
Comment 13 Adam Purkrt 2011-06-05 09:25:20 CEST
Created attachment 3719 
patch-no-2a

apologies, I used diff the wrong way - here is the correct patch
Comment 14 Adam Purkrt 2011-06-05 09:35:06 CEST
Um, yeah, so after patch-no-2a, the applist indeed is not in "Extralight" (but in "Book" how it should be),

but also the headings ("Recommended applications", "Other applications") are no longer semibold...
Comment 15 Nick Schermer editbugs 2012-11-06 18:04:39 CET
Obviously a bug in gtk, but setting weight-set before weight works. Fixed in bddf31b.

Bug #7688

Reported by:
Adam Purkrt
Reported on: 2011-06-03
Last modified on: 2012-11-06

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Attachments

window-shot of the open with dialog (with too thin a font) (31.80 KB, image/jpeg)
2011-06-03 17:32 CEST , Adam Purkrt
no flags
this-is-imo-better (33.11 KB, image/jpeg)
2011-06-03 18:37 CEST , Adam Purkrt
no flags
it works fine after this change (patch against v1.2.2) (1.05 KB, patch)
2011-06-03 18:49 CEST , Adam Purkrt
no flags
font-dejavu-sans-bold-applist-still-extralight (34.49 KB, image/jpeg)
2011-06-03 19:28 CEST , Adam Purkrt
no flags
patch-no-2 (801 bytes, patch)
2011-06-05 09:19 CEST , Adam Purkrt
adam : review-
patch-no-2a (801 bytes, patch)
2011-06-05 09:25 CEST , Adam Purkrt
no flags

Additional information