! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
gnome-terminal unexpectedly resized
Status:
RESOLVED: FIXED

Comments

Description suckfish 2011-03-26 00:44:27 CET
Running under xfwm4, my gnome-terminal windows keep on getting unexpectedly resized to a uselessly small size.

This is triggered in several ways:
+ maximize then unmaximize the window.
+ open a new tab
+ change xfwm settings (e.g, turn compositing off/on)
Comment 1 Tony Houghton 2011-08-01 16:16:57 CEST
I can confirm this. I think it's since gnome-terminal started using GTK3 and the new version of vte that goes with it. roxterm is similarly affected. There is another report of it at <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632403>.

The exact symptoms seem to depend on some factors like font size and GTK theme.
Comment 2 Olivier Fourdan editbugs 2011-08-01 18:37:56 CEST
sIt's a bug either in VTE or gnome-terminal which sets its size increment and size hints in such a way that the size is not a multiple of the increments.

A well behaved window manager will resize the window to match the size increments specified and gnome-terminal will try to resize again, thus causing a loop between the window manager and the app.

But the bug is in gnome-terminal (or in VTE, dunno), and not in the window manager. 

The same happens in KDE's kwin. I have relaxed the rules in xfwm4 to avoid this (I thinkI committed that in git, not sure), but the bug lies in the app itself, and not in the window manager.
Comment 3 Tony Houghton 2011-08-01 20:14:26 CEST
Thanks. I don't think it's likely that vte is returning incorrect cell sizes, so both gnome-terminal and roxterm must be missing something they should be adding to the base_width/height fields.
Comment 4 Tony Houghton 2011-08-03 01:10:14 CEST
I've tried to debug roxterm and I again/still think there's a problem with xfwm4. If I maximize then un-maximize the size allocation of the vte widget isn't the same as before maximization and the shrinkage occurs.

For example, the geometry hints are set with a base width and height of 2 (derived from vte's inner-border property) and increments of 7 and 15. For the initial window I just let it size itself to fit the terminal after calling vte_terminal_set_size (which takes columns and rows as arguments). The initial allocation is 562x542 which fits the geometry hints and configured rows and colums. Maximizing gives an allocation of 1340x684 (neither dimension fits the geometry hints). Unmaximizing is where it gets interesting. The allocation width correctly returns to 562 but for some reason the height is 537 instead of 542. Then it goes down in steps of 15.
Comment 5 Tony Houghton 2011-08-06 15:12:22 CEST
I found another report at <https://bugzilla.gnome.org/show_bug.cgi?id=649680>. We now think the bug is in gtk3. Can someone who understands xfwm4 well offer any insight into what gtk3 might be doing wrong?
Comment 6 Olivier Fourdan editbugs 2011-09-09 14:39:18 CEST
Should be fixed with git commit bf911e27 which makes xfwm4 less strict on size increments.

see https://bugzilla.xfce.org/show_bug.cgi?id=4728#c16
Comment 7 Christoph Wickert editbugs 2011-10-06 09:52:36 CEST
With that change you have broken horizontal and vertical maximizing for some apps like Xfce's Terminal.

Try this:
Assign keyboard shortcuts for maximizing windows horizontally and vertically, e.g. SUPER+H and SUPER+V. Open Xfce's Terminal and press shortcut twice. Terminal maximizes but the second keystroke doesn't minimize it again. Without the patch the maximization is correctly toggled.
Comment 8 Olivier Fourdan editbugs 2011-10-11 08:43:59 CEST
Fixed with git commit e77b4762e1484fe36f37347bc3d691f30ea791b3
Comment 9 Olivier Fourdan editbugs 2011-11-14 09:09:24 CET
*** Bug 8144 has been marked as a duplicate of this bug. ***
Comment 10 Olivier Fourdan editbugs 2011-12-06 09:13:01 CET
*** Bug 8224 has been marked as a duplicate of this bug. ***
Comment 11 Frédéric Delanoy 2012-12-06 13:25:34 CET
(In reply to comment #8)
> Fixed with git commit e77b4762e1484fe36f37347bc3d691f30ea791b3

Sorry to resurrect this bug, but I tried with Ubuntu 12.04 64 bit (4.8.3-1ubuntu1.1) and it still hits me.

Upgrading to 4.10 (using https://launchpad.net/~xubuntu-dev/+archive/xfce-4.10) doesn't help.
Comment 12 Frédéric Delanoy 2012-12-06 13:28:50 CET
(In reply to comment #11)
> (In reply to comment #8)
> > Fixed with git commit e77b4762e1484fe36f37347bc3d691f30ea791b3
> 
> Sorry to resurrect this bug, but I tried with Ubuntu 12.04 64 bit
> (4.8.3-1ubuntu1.1) and it still hits me.

I mean xfwm4 version 4.8.3-1ubuntu1.1
Comment 13 Olivier Fourdan editbugs 2012-12-06 13:33:12 CET
(In reply to comment #12)
> I mean xfwm4 version 4.8.3-1ubuntu1.1

The fix is in 4.10 and not backported in 4.8 - I am not using Xubuntu, but it works for me here.
Comment 14 Frédéric Delanoy 2012-12-06 14:06:50 CET
(In reply to comment #13)
> (In reply to comment #12)
> > I mean xfwm4 version 4.8.3-1ubuntu1.1
> 
> The fix is in 4.10 and not backported in 4.8 - I am not using Xubuntu, but
> it works for me here.

Apparently your initial fix (bf911e27) was made between 4.8.1 and 4.8.2 (comment 6).
And the "successor" e77b4762e1484fe36f37347bc3d691f30ea791b3 between 4.8.2 and 4.8.3 (on 2011-10-11 according to http://git.xfce.org/xfce/xfwm4/log/?h=xfce-4.8).

So I guess it really was backported, and should work with 4.8.3 (upgraded to ubuntu 12.04 yesterday), no?

Doesn't work with 4.10 for me either.

Have you a way of testing on up-to-date ubuntu 12.04?
Comment 15 Olivier Fourdan editbugs 2012-12-06 14:14:05 CET
(In reply to comment #14)
> Have you a way of testing on up-to-date ubuntu 12.04?

Not really.

But this particular bug is fixed with the given commit, so if you still have a problem with GNOME terminal from GNOME3 it's most likely something else (I am not saying you don't have an issue, all I am saying is that it's a different one).

Bug #7445

Reported by:
suckfish
Reported on: 2011-03-26
Last modified on: 2012-12-06
Duplicates (2):
  • 8144 Restore after vertical maximization broken by 4.8.2
  • 8224 Horizontal & Vertical maximize go only part way, and un-maximize is broken (using xfce4 WM)

People

Assignee:
Olivier Fourdan
CC List:
5 users

Version

Version:
unspecified

Attachments

Additional information