! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix abicheck to handle ppc64 architecture
Status:
RESOLVED: FIXED
Product:
Libxfce4util
Component:
General

Comments

Description Colin Watson 2011-03-15 16:26:24 CET
Created attachment 3564 
Fix abicheck to handle ppc64 architecture

According to Alan Modra, the PowerPC64 ABI defines function symbols on their OPD entry, in the .opd section which is part of the data segment; so functions on this architecture have symbol type D in nm.  The attached patch updates abicheck to handle this.
Comment 1 Colin Watson 2011-03-15 16:31:18 CET
This patch needs to be applied to quite a few components.  Do you need separate bug reports and patches for them all?  I'm guessing it would be quicker for somebody who already has everything checked out to just do everything in one shot ...

Compare also bug 7009, although the 32-bit and 64-bit ABIs are slightly different.
Comment 2 Nick Schermer editbugs 2011-03-15 17:33:57 CET
No, this patch is ok, I can apply it to all other components too.
Comment 3 Nick Schermer editbugs 2011-03-25 11:55:00 CET
The check was also not properly working in solaris, not because of the D-type but also because sun studio and nm output was different, so here is the latest attempt (for xfconf):

${CPP:-cpp} -E -DINCLUDE_INTERNAL_SYMBOLS -DINCLUDE_VARIABLES -DALL_FILES ${srcdir:-.}/xfconf.symbols | sed 's/ G_GNUC.*$//;s/ PRIVATE//;/^#.*$/d;/^$/d' | sort > expected-abi
nm -D -g -P .libs/libxfconf-0.so | awk '$2~/^[DRTG]$/&&$1~/^[^_]/{print $1}' | sort > actual-abi
diff -u expected-abi actual-abi && rm expected-abi actual-abi

Could someone test this on ppc64 too?
Comment 4 Nick Schermer editbugs 2011-03-25 18:16:27 CET
Xfconf has the first fix: http://git.xfce.org/xfce/xfconf/commit/?id=a2d91c0e7ec3fa327b68dbc26809d40a5592307f once confirmed this works I'll apply it in the other modules too.
Comment 5 Landry Breuil editbugs 2015-03-11 22:33:48 CET
*** Bug 9146 has been marked as a duplicate of this bug. ***
Comment 6 Landry Breuil editbugs 2015-03-11 22:36:47 CET
Better late than never, applied in fa04406

Bug #7416

Reported by:
Colin Watson
Reported on: 2011-03-15
Last modified on: 2015-03-11
Duplicates (1):
  • 9146 fix build failure on ppc64

People

Assignee:
Nick Schermer
CC List:
3 users

Version

Version:
Unspecified

Attachments

Additional information