6805 – segmentation fault when creating empty directories to target disc

segmentation fault when creating empty directories to target disc

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
major

Product:
Xfburn

Component:

general

Comments

Description Matteo 'Peach' Pescarin 2010-11-10 21:10:07 CET

Steps to repro:
* create a new project/compilation
* create a new dir in the target compilation
* hit the burn button

Expected results:
* it should go straight to the "confirm-burn" panel

Actual results:
* it blows up pretty badly

This is the output if launched from the command line:

$ xfburn 
** Message: Thunar-VFS not available, using default implementation
** Message: Using basic transcoder.

(xfburn:21274): GLib-CRITICAL **: g_path_get_basename: assertion `file_name != NULL' failed
Segmentation fault

Distro is Gentoo, you can see the bug opened here:
http://bugs.gentoo.org/show_bug.cgi?id=331135

$ xfburn --version
xfburn version 0.4.3 for Xfce 4.6.2
        built with GTK+-2.20.1, linked with GTK+-2.20.1.

Comment 1 Samuli Suominen 2010-12-18 19:57:17 CET

Also, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=592524

Comment 2 manu 2011-03-06 08:50:20 CET

Created attachment 3541 
Patch to avoid segfault when adding new directory

I had opened another bug report on Debian ( http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613563 ) , and I suggest this patch to correct it.

Thanks

Comment 3 Yves-Alexis Perez editbugs

2012-02-19 16:54:37 CET

I'm not sure about the patch, but could someone review it and ack/nack it? And commit it if it's ack'able.

Comment 4 Matteo 'Peach' Pescarin 2012-02-19 17:03:17 CET

just tried to reproduce the behaviour with new Xfburn 0.4.3,
everything went fine without problems.

Thanks for your support, feel free to close this bug.

Comment 5 Yves-Alexis Perez editbugs

2012-02-19 17:05:41 CET

Well, we had a comment from a Debian user saying that it /was/ reproducible on 0.4.3 and Lionel Le Folgoc confirmed.

Comment 6 Samuli Suominen 2012-02-19 17:08:18 CET

Yeah, keep the bug open -- the fix is not in 0.4.3 or git, but only attached here

Comment 7 Matteo 'Peach' Pescarin 2012-02-19 17:13:12 CET

well if that's the case, let me know if you need any info on my system, flags.

Comment 8 Lionel Le Folgoc 2012-02-19 17:38:27 CET

Created attachment 4225 
full bt

Here's a full stacktrace for reference (might be useful later).

It crashes at xfburn-data-composition.c:1858 apparently:
if (strcmp (basename, name) != 0) {

So maybe a simpler fix is to use g_strcmp0() since it handles NULL?

Anyway, +1 for a review of the patch. ;-)

Comment 9 Samuli Suominen 2012-05-31 23:18:09 CEST

Created attachment 4481 
Same patch but reformatted to apply for git

This is the same already posted patch but cleaned up format so it applies with current git.

Comment 10 David Mohr 2012-07-08 02:07:12 CEST

I remembered this issue while traveling, so I coded up a slightly different fix.

Thanks everyone for the work though!

commit 611d915887b09148e74c28704dc5a0bef16d90fd
Author: David Mohr <david@mcbf.net>
Date:   Sat Jun 16 17:22:55 2012 +0200

    Don't check source file for user created directories.

Comment 11 Christoph Wickert editbugs

2012-09-28 20:52:30 CEST

*** Bug 6726 has been marked as a duplicate of this bug. ***

Comment 12 Christoph Wickert editbugs

2012-09-28 20:57:23 CEST

*** Bug 7285 has been marked as a duplicate of this bug. ***

Bug #6805

Reported by:
Matteo 'Peach' Pescarin

Reported on: 2010-11-10
Last modified on: 2012-09-28

Duplicates (2):

6726 xfburn-0.4.3-1.fc12: strcmp: Process /usr/bin/xfburn was killed by signal 11
7285 Segmentation fault when using empty AUDIO_TS

People

Assignee:
Xfburn Bug Triage

CC List:
7 users

Version

Version:
unspecified

Target Milestone:
---

Attachments

Patch to avoid segfault when adding new directory (1.55 KB, patch) 2011-03-06 08:50 CET , manu	no flags
full bt (13.45 KB, text/plain) 2012-02-19 17:38 CET , Lionel Le Folgoc	no flags
Same patch but reformatted to apply for git (1.59 KB, patch) 2012-05-31 23:18 CEST , Samuli Suominen	no flags

Additional information