! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Unable to type in the panel with 'focus follows mouse' enabled
Status:
RESOLVED: FIXED

Comments

Description charlie-tca 2010-08-19 18:46:14 CEST
This bug has been reported to Ubuntu Launchpad as:
https://bugs.launchpad.net/bugs/571608

When the text panel is enabled for xfce4-dict (Xfce Panel Dictionary Plugin), I am unable to focus on the text panel and type text in. Typed text goes to the previously focused application. When running the application by clicking on the icon, one is able to type in the search text in the application window.

From the comments on the Launchpad report:
> Robert, are you using 'focus follows mouse' also? If so, could you
> change it in "Applications -> Settings -> Xfce 4 Settings Manager ->
> Window Manager, Focus tab, Focus model = click to focus". Does this
> change the behaviour of the plugin? If "focus follows mouse" is set,

Yes, the issue only occurs when focus follows mouse is set.

> then the applet is working correct, since the focus will be wherever the
> mouse pointer is.

It does not work correctly. When I move the mouse pointer over the text area
of the dictionary, or even click inside it, focus does not go to it.
Comment 1 Christoph Wickert editbugs 2010-09-09 09:38:24 CEST
I guess this is a duplicate of bug 6617
Comment 2 Olivier Fourdan editbugs 2010-10-18 09:01:31 CEST
(In reply to comment #1)
> I guess this is a duplicate of bug 6617

Possibly.

The panel is of type "dock" and as such will not be focused by the window manager *unless* it explicitely ask for focus.

Bug 6617 mentions it could be a regression, what was the last know working version?
Comment 3 Nick Schermer editbugs 2010-11-09 09:17:45 CET
*** Bug 6617 has been marked as a duplicate of this bug. ***
Comment 4 Olivier Fourdan editbugs 2010-12-03 18:54:20 CET
I believe this is a bug in the panel or the plugin (the panel I believe) that does not use the "source is application" field in the event, but uses a zero timestamp instead (old protocol)

xfwm4 now implements a workaround, yet it would be interesting to fix it properly (for example, metacity will issue a warning in this case)
Comment 5 Kevin Fenzi 2011-06-08 15:23:18 CEST
What version/commit was this workaround commited in? 

I am still seeing reports of this with 4.8.1... ;( 

https://bugzilla.redhat.com/show_bug.cgi?id=630964
Comment 6 Olivier Fourdan editbugs 2011-06-08 15:32:43 CEST
(In reply to comment #5)
> What version/commit was this workaround commited in? 
> 
> I am still seeing reports of this with 4.8.1... ;( 
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=630964

long time ago:

http://git.xfce.org/xfce/xfwm4/commit/src?id=92c058c1f11f91716fd6374a195097968b3bd01e

So either the fix doesn't work or it's some other b0rkage
Comment 7 Kevin Fenzi 2011-06-11 20:16:29 CEST
Yeah, I can confirm it's still here with the verve plugin at least...

xfce4-verve-plugin-1.0.0-2.fc15.x86_64
xfce4-panel-4.8.3-2.fc15.x86_64
xfwm4-4.8.1-2.fc15.x86_64
Comment 8 Markus Schwarzenberg 2011-09-02 23:17:39 CEST
Created attachment 3848 
patch for xfce4-panel-4.8.5/panel/panel-window.c

Bug is still existing in xfce4-panel-4.8.5 (checked with verve command line
and smart bookmark plugin) and can be fixed (...works for me) using the attached patch. 

Note that the panel plugins got their focus with some other window managers
(tested: fvwm, openbox).
Comment 9 Nick Schermer editbugs 2011-09-08 10:55:47 CEST
I don't see how this patch makes a difference.
Comment 10 Olivier Fourdan editbugs 2011-09-08 11:16:30 CEST
(In reply to comment #9)
> I don't see how this patch makes a difference.

It changes the source indication of NET_ACTIVE_WINDOW:

    http://standards.freedesktop.org/wm-spec/wm-spec-1.4.html#id2550738

    http://standards.freedesktop.org/wm-spec/wm-spec-1.4.html#sourceindication

The window manager will honor the request as it pretendly comes from a pager.
Comment 11 Nick Schermer editbugs 2011-09-08 17:10:35 CEST
Setting it to 2 still doesn't fix the mouse-follow-focus handling.
Comment 12 Olivier Fourdan editbugs 2011-09-09 12:48:23 CEST
Should be fixed with commit 5a4a1b0

Bug #6649

Reported by:
charlie-tca
Reported on: 2010-08-19
Last modified on: 2011-09-09
Duplicates (1):
  • 6617 verve-focus doesn't work anymore in focus follow mouse

People

Assignee:
Olivier Fourdan
CC List:
9 users

Version

Version:
unspecified

Attachments

patch for xfce4-panel-4.8.5/panel/panel-window.c (461 bytes, patch)
2011-09-02 23:17 CEST , Markus Schwarzenberg
no flags

Additional information