! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] fix workaround for changed libwnck signal "active-workspace-changed"
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description slack 2010-08-15 05:45:43 CEST
Created attachment 3078 
fix selfmade workspace_changed_cb call

Link against libwnck-2.18.3 (old variant of the signal callback!) and change the desktop setting "Icons/Appearance/Icon type" to "Minimized application icons". This lets xfdesktop crash...

There is a autodetection logic inside the handler to work around an API change.
This workaround works and it expects the old API, but there is also a selfmade call to the handler from within the application but it is using the new API only.

The fix uses the same logic as used inside the handler to match the API of the library.

I really hope this will finally end your ignorance of the numerous bug reports related to this crash in the last two years ;-)

Thanks
Comment 1 Jannis Pohlmann editbugs 2010-11-14 17:46:29 CET
Fixed in a different way: Xfce 4.8 depends on libwnck >= 2.22 so we can safely assume the new signal signature in xfdesktop. Workaround removed:

commit 6dbd07e89bf85d096595a823ba7fb6171f71f493
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Sun Nov 14 17:43:48 2010 +0100

    Depend on wnck >= 2.22, no longer use signal workarounds (bug #6638).

Bug #6638

Reported by:
slack
Reported on: 2010-08-15
Last modified on: 2010-11-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
2 users

Version

Attachments

Additional information