! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-wavelan-plugin-0.5.5 fails to build with xfce4-panel-4.7 (missing libxf...
Status:
RESOLVED: FIXED
Product:
Xfce4-wavelan-plugin
Component:
General

Comments

Description Samuli Suominen 2010-08-07 16:00:49 CEST
Created attachment 3059 
Missing libxfcegui4 XDT check and LIBS/CFLAGS.

Because xfce4-panel-4.7 is now using libxfce4ui instead of libxfcegui4, this is required or otherwise build bails out on:

xfce4_wavelan_plugin-wavelan.o: In function `wavelan_configure':
wavelan.c:(.text+0xed9): undefined reference to `xfce_create_header'

Attached patch fixes the issue
Comment 1 Landry Breuil editbugs 2010-08-08 09:00:04 CEST
Fixed too, thanks.
Comment 2 Samuli Suominen 2010-08-08 09:15:55 CEST
nice
Comment 3 Yves-Alexis Perez editbugs 2010-11-06 09:58:54 CET
There's a typo in the patch, see following diff:


diff --git a/panel-plugin/Makefile.am b/panel-plugin/Makefile.am
index 5e06216..61d06b1 100644
--- a/panel-plugin/Makefile.am
+++ b/panel-plugin/Makefile.am
@@ -10,9 +10,9 @@ plugin_PROGRAMS = xfce4-wavelan-plugin
 #plugin_LTLIBRARIES =							\
 #	libwavelan.la
 
-xfce4_wavelan_plugin_LDFLAGS =							\
+xfce4_wavelan_plugin_LDADD =							\
 				@LIBXFCE4PANEL_LIBS@				\
-				@LIBXFCEGUI4L_LIBS@
+				@LIBXFCEGUI4_LIBS@
 
 xfce4_wavelan_plugin_SOURCES =							\
 	wavelan.c							\

(not so sure about the s/LDFLAGS/LDADD/ but it seems that it's the norm elsewhere).
Comment 4 Florian Rivoal editbugs 2010-11-07 12:18:18 CET
Thanks for noticing. Just applied (and pushed) your fix.

As for the difference between LDADD and LDFLAGS, LDADD is indeed the correct one here. If you look at the generated Makefile, the parameters passed to the linker are, first the LDFLAGS, then the list of .o files, then the LDADD.

The order of the object files and libraries passed to the linker matters, and dependencies should appear after things that depends on them, otherwise, the linker might discard them as unneeded. It will do just that for example if you use the -Wl,--as-needed parameter as part of LDFLAGS, which is something some (most?) distributions do.

Bug #6615

Reported by:
Samuli Suominen
Reported on: 2010-08-07
Last modified on: 2010-11-07

People

Assignee:
Florian Rivoal
CC List:
3 users

Version

Version:
0.5.5 or older
Target Milestone:
0.5.5 or older

Attachments

Missing libxfcegui4 XDT check and LIBS/CFLAGS. (1012 bytes, application/octet-stream)
2010-08-07 16:00 CEST , Samuli Suominen
no flags

Additional information