! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[thunarx-2 branch] Port to exo-1
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Thunar-media-tags-plugin
Component:
General

Comments

Description Lionel Le Folgoc 2010-03-07 17:45:11 CET
Created attachment 2878 
proposed patch

Hi,

The current version of the plugin in the thunarx-2 branch still uses exo_gtk_object_ref_sink(), which has been removed from exo >= 0.5.0.

Since apparently everything is moving from exo-0.3 to exo-1, it may be a good idea to switch to g_object_ref_sink() instead.

The attached patch fixes this issue.
Comment 1 Nick Schermer editbugs 2010-03-08 16:48:15 CET
Better to switch to the new tooltip api in gtk and depend on gtk 2.12.
Comment 2 Lionel Le Folgoc 2010-03-08 20:31:25 CET
Created attachment 2882 
proposed patch (switch to the new tooltip api, depends on gtk 2.12, and switch to exo-1)
Comment 3 Lionel Le Folgoc 2010-12-16 09:46:12 CET
*** Bug 6958 has been marked as a duplicate of this bug. ***
Comment 4 Lionel Le Folgoc 2010-12-16 21:53:03 CET
Created attachment 3284 
thunar-plugin/Makefile.am fix

Also, the plugin uses some symbols from libexo, but doesn't explicitly link against it. This patch seems to fix the issue here.
Comment 5 Mathias Brodala 2011-04-10 21:19:20 CEST
(In reply to comment #4)
> Created attachment 3284 
> thunar-plugin/Makefile.am fix
> 
> Also, the plugin uses some symbols from libexo, but doesn't explicitly link
> against it. This patch seems to fix the issue here.

Thanks for your patches. With them and the thunarx-2 branch I was finally able to port the plugin to Xfce 4.8. Integration in Thunar’s bulk renamer works just fine.

However, the properties tab is weird: I can put the cursor into one of the fields and after 1 second the field is unfocused. If I quickly focus a field and start entering something my change disappears after the same delay.

Any idea what might be wrong? I’d assume that you don’t have such an issue.
Comment 6 Lionel Le Folgoc 2011-04-11 19:12:30 CEST
I've the same issue.
Comment 7 Mathias Brodala 2011-04-11 20:08:10 CEST
(In reply to comment #6)
> I've the same issue.

The reason seems to be that ThunarxFileInfo constantly emits the "changed" signal every second.
Comment 8 Jannis Pohlmann editbugs 2011-04-11 21:47:05 CEST
That should not happen unless something else changes the file every second. The only other reason I can think of is that you don't have fam/gamin installed and thus, GIO might be polling for file changes frequently. But even then it should only generate that signal if the file has changed.
Comment 9 Mathias Brodala 2011-04-11 21:56:52 CEST
(In reply to comment #8)
> That should not happen unless something else changes the file every second.

It seems Thunar’s properties dialog does. I prepared a GFileMonitor before opening the dialog for a file and as soon as the dialog is open, the GFileMonitor starts emitting its "changed" signal at exactly the mentioned 1 second interval.

> The
> only other reason I can think of is that you don't have fam/gamin installed and
> thus, GIO might be polling for file changes frequently. But even then it should
> only generate that signal if the file has changed.

Gamin is installed here.
Comment 10 Jannis Pohlmann editbugs 2011-04-11 22:53:29 CEST
(In reply to comment #9)
> (In reply to comment #8)
> > That should not happen unless something else changes the file every second.
> 
> It seems Thunar’s properties dialog does. I prepared a GFileMonitor before
> opening the dialog for a file and as soon as the dialog is open, the
> GFileMonitor starts emitting its "changed" signal at exactly the mentioned 1
> second interval.

The properties dialog doesn't do that by itself. It has to be either one of the properties page plugins (media tags plugin in git doesn't do anything with the file unless you change something) or something inside GIO... dunno.
Comment 11 Mathias Brodala 2011-04-11 23:34:59 CEST
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > That should not happen unless something else changes the file every second.
> > 
> > It seems Thunar’s properties dialog does. I prepared a GFileMonitor before
> > opening the dialog for a file and as soon as the dialog is open, the
> > GFileMonitor starts emitting its "changed" signal at exactly the mentioned 1
> > second interval.
> 
> The properties dialog doesn't do that by itself. It has to be either one of the
> properties page plugins (media tags plugin in git doesn't do anything with the
> file unless you change something) or something inside GIO... dunno.

That I can confirm at least. The GFileMonitor stays silent if I uninstall the media tags plugin and open the file properties dialog.
Comment 12 Nick Schermer editbugs 2011-11-30 18:26:21 CET
Applied.

Bug #6295

Reported by:
Lionel Le Folgoc
Reported on: 2010-03-07
Last modified on: 2011-11-30
Duplicates (1):
  • 6958 thunar crash when opening properties of a media file

People

Assignee:
Jannis Pohlmann
CC List:
3 users

Version

Version:
unspecified

Attachments

Additional information