! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
use preferred hal mount point
Status:
RESOLVED: INVALID

Comments

Description Yves-Alexis Perez editbugs 2009-11-06 06:58:27 CET
Created attachment 2658 
use hal desired mount point

Hey,

not so long ago I told you about some debian users which were cooking a patch
to implement the “preferred hal mount point” stuff.

They did manage to cleanup their patches so I'm attaching them here. But they
don't have time to handle the submission at the moment, so if you have any
question regarding this, I'm adding them to CC: and they'll handle it when they
have time.

Cheers,
Comment 1 Yves-Alexis Perez editbugs 2009-11-06 07:00:14 CET
Created attachment 2659 
auto_mount.patch (?)
Comment 2 Yves-Alexis Perez editbugs 2009-11-06 07:01:10 CET
Ok in fact I can't add an email from a non user to the bug report so I'll warn them. Cheers.
Comment 3 Otavio Salvador 2009-11-06 11:54:57 CET
Those patches has been in use here at O.S. Systems for a while.
Comment 4 Nick Schermer editbugs 2009-11-07 08:57:07 CET
I can't get a clue what those patches should do. A desired_mount_point variable is used, but it is never set anywhere, it *looks* is is against exo-mount, but i see function names that are not in our code.

So explain what the patch should do. Read the volume.policy.desired_mount_point property?
Comment 5 Otavio Salvador 2009-11-07 16:50:24 CET
Hello,

Sorry but I fail to remember all the details for it; we've been using those patches to fix issues we had in our thinclient OS (that uses pcmanfm) with automounting.

The issues we had are:

 - it failed to respect the hal preference of mounting point (if set)
 - pcmanfm failed to properly call the mounting routines resulting in it raising an error if the path doesn't exist instead of handling it and creating it back

With those it works fine.
Comment 6 Yves-Alexis Perez editbugs 2009-11-07 18:40:51 CET
Yo(In reply to comment #5)
> Hello,
> 
> Sorry but I fail to remember all the details for it; we've been using those
> patches to fix issues we had in our thinclient OS (that uses pcmanfm) with
> automounting.
> 
> The issues we had are:
> 
>  - it failed to respect the hal preference of mounting point (if set)
>  - pcmanfm failed to properly call the mounting routines resulting in it
> raising an error if the path doesn't exist instead of handling it and creating
> it back

You _do_ know that pcmanfm use code rippen from exo but no exo itself? Basically it's just a crappy embedded code copy. If you want to improve exo, then do it against exo, not pcmanfm. If you want to improve pcmanfm, then report to pcmanfm people (and even better, tell them to use exo directly instead :) ).

Cheers,
Comment 7 Otavio Salvador 2009-11-07 18:51:52 CET
I didn't know and to be sincere I didn't worry about it. At that time I was interested in fixing my problem and so I did.

Well; the patches are here; use it or drop it all ;-)

Anyway, thanks by looking at it.

Cheers,
Comment 8 Yves-Alexis Perez editbugs 2009-11-07 19:04:19 CET
(In reply to comment #7)
> I didn't know and to be sincere I didn't worry about it. At that time I was
> interested in fixing my problem and so I did.
> 
> Well; the patches are here; use it or drop it all ;-)

We can't, the patches are just useless for Xfce, they are against something we don't even know.
Comment 9 Yves-Alexis Perez editbugs 2010-08-05 06:29:08 CEST
Closing as invalid

Bug #5953

Reported by:
Yves-Alexis Perez
Reported on: 2009-11-06
Last modified on: 2010-08-05

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Version:
0.3.105

Attachments

use hal desired mount point (2.94 KB, patch)
2009-11-06 06:58 CET , Yves-Alexis Perez
no flags
auto_mount.patch (?) (478 bytes, patch)
2009-11-06 07:00 CET , Yves-Alexis Perez
no flags

Additional information