! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-places-plugin exo_url build errors with exo-1
Status:
RESOLVED: FIXED
Product:
Xfce4-places-plugin
Component:
General

Comments

Description Evaggelos Balaskas 2009-09-10 19:35:29 CEST
--- support.c	2009-09-11 00:07:30.539196716 +0300
+++ support.c.ebal	2009-09-11 00:08:22.075868949 +0300
@@ -52,10 +52,9 @@
 
     if(path != NULL && *path != '\0'){
 
-        DBG("exo_url_show(%s)", path);
-        exo_success = exo_url_show(path, NULL, NULL);
+    GError         *error = NULL;
 
-        if(!exo_success){
+        if ( !gtk_show_uri (NULL, path, 0, &error)){
             gchar *cmd = g_strconcat("thunar \"", path, "\"", NULL);
             DBG("exec: %s", cmd);
             places_gui_exec(cmd);
@@ -114,8 +113,9 @@
 void
 places_load_file(const gchar *path)
 {
+    GError         *error = NULL;
     if(path != NULL && *path != '\0')
-        exo_url_show(path, NULL, NULL);
+            gtk_show_uri (NULL , path, 0, &error);
 }
 
 /**
Comment 1 Diego Ongaro 2010-05-23 02:15:06 CEST
I assume your goal is to build with the library exo-1 instead of exo-0.3. Unfortunately, my version of Thunar depends on exo-0.3, and I don't have the time now to set up the latest code from git.

I'll let this patch keep sitting for now. Sorry.
Comment 2 Samuli Suominen 2010-09-10 07:45:36 CEST
I can confirm the patchs allows compilation against exo-0.5.4 and works.

But you need to change configure.in to check for exo-1 instead of exo-0.3 too for pkg-config.
Comment 3 Skunnyk 2011-01-10 22:34:22 CET
Created attachment 3336 
Fix and clean build for xfce4-places-plugin

Hi,

In attachement an enhanced patch to support exo >= 0.5 and xfce4-panel >= 4.7
Comment 4 Mukund Sivaraman 2011-11-25 18:20:59 CET
Created attachment 3983 
Use the preferred filemanager

(In reply to comment #3)
> Created attachment 3336 
> Fix and clean build for xfce4-places-plugin
> 
> Hi,
> 
> In attachement an enhanced patch to support exo >= 0.5 and xfce4-panel >= 4.7

It seems Fedora 16 has picked up some variant of the patch in attachment 3336 . However, it fails to launch the preferred filemanager when a different one from Thunar is configured such as Nautilus.

This patch, when applied over the patch in attachment 3336  causes the preferred filemanager to be correctly launched:

--- a/panel-plugin/support.c
+++ b/panel-plugin/support.c
@@ -51,10 +51,8 @@ places_load_file_browser(const gchar *path)
     gboolean exo_success;
 
     if(path != NULL && *path != '\0'){
-
-    GError         *error = NULL;
-
-        if ( !gtk_show_uri (NULL, path, 0, &error)){
+        if(!exo_execute_preferred_application("FileManager", path,
+                                              NULL, NULL, NULL)) {
             gchar *cmd = g_strconcat("thunar \"", path, "\"", NULL);
             DBG("exec: %s", cmd);
Comment 5 Christoph Wickert editbugs 2012-08-31 23:37:44 CEST
AFAICS this is fixed in 1.4.0. Close?
Comment 6 Samuli Suominen 2012-09-01 10:05:58 CEST
(In reply to comment #5)
> AFAICS this is fixed in 1.4.0. Close?

I concur after reviewing the code of -places-plugin-1.4.0/panel-plugin/support.c (and I'm closing the bug as such)

Bug #5754

Reported by:
Evaggelos Balaskas
Reported on: 2009-09-10
Last modified on: 2012-09-01

People

Assignee:
Florian Rivoal
CC List:
2 users

Version

Version:
unspecified

Attachments

Fix and clean build for xfce4-places-plugin (4.92 KB, patch)
2011-01-10 22:34 CET , Skunnyk
no flags
Use the preferred filemanager (955 bytes, patch)
2011-11-25 18:20 CET , Mukund Sivaraman
no flags

Additional information