! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Icon unaccessible when XOAP error
Status:
RESOLVED: FIXED
Product:
Xfce4-weather-plugin
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2009-06-12 13:20:37 CEST
Hi,

a debian user reported that it might be difficult to access the right clic menu of weather plugin because no icon is displayed.

More info if you need can be shown at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=510215

Cheers,
Comment 1 Jannis Pohlmann editbugs 2009-06-12 13:21:48 CEST
Re-assigning to Colin Leroy who is the new maintainer of the plugin.
Comment 2 Colin Leroy 2009-06-13 07:41:16 CEST
This should be fixed in SVN r7549.
Comment 3 Yves-Alexis Perez editbugs 2009-06-17 21:19:41 CEST
Hmhm, I still get those messages:

(xfce4-weather-plugin:31241): weather-WARNING **: Unable to open image: /usr/share/xfce4/weather/icons/liquid/-.png


It seems that the fix is wrong. It only uses 99.png when there's no filename, but here the filename exists and is '-'. So I guess checking for that character should fix the problem in the end?
Comment 4 Colin Leroy 2009-06-17 21:39:32 CEST
My patch didn't remove the warning on failure to get the asked-for icon. Instead, it loads 99.png after warning:

  image = gdk_pixbuf_new_from_file_at_scale (filename, size, size, TRUE, NULL);

  if (G_UNLIKELY (!image)) {
    g_warning ("Unable to open image: %s", filename); /* this is what you see */
    /* this checks that we asked for another image than the default "99"
    if (number && strcmp(number, "99")) {
      g_free(filename);
      /* and in this case it returns it. */
      return get_icon("99", size);
    }
  }

In the end, even with the warning, the icon should be displayed.
Comment 5 Yves-Alexis Perez editbugs 2009-06-18 05:18:08 CEST
Hmhmh, ok, correct. But then it floods .xsession-errors :)

Bug #5456

Reported by:
Yves-Alexis Perez
Reported on: 2009-06-12
Last modified on: 2010-11-09

People

Assignee:
Colin Leroy
CC List:
2 users

Version

Version:
0.7.3 or older

Attachments

Additional information