! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
File manager and progress indicator windows lock up during a copy on OpenBSD.
Status:
RESOLVED: WORKSFORME

Comments

Description Edd Barrett 2009-01-18 17:43:51 CET
Created attachment 2091 
Screenshot showing the bug

Hi,

When I copy a folder with some fairly large files in (in my test a folder containing some OGG Vorbis files), the file manager windows and progress bar windows lock up. After a while the progress window dissappears and the file manager windows update and continue to work. It makes thunar feel horrible for me, which is a shame as the rest of the XFCE stuff is so good.

This sounds like something to do with threading? Perhaps the GUI needs to be updated more often, but then I am no expert.

I attach a screen-shot showing the bug.

This was on Thunar-0.9.3, on OpenBSD-4.4-current/i386 (2 machines here display this behavior).

If this has been fixed in SVN, can we please have a patch, so we can back-port it. I am in contact with the port maintainer and can send him a diff against the current port in the OpenBSD tree.

Thanks
Comment 1 Edd Barrett 2009-01-18 17:44:26 CET
When I say copy, I mean drag and drop between two Thunar windows, by the way.
Comment 2 Benedikt Meurer editbugs 2009-01-18 21:10:25 CET
Hm, sounds like a threading bug in OpenBSD's pthread implementation. The actual copy runs in a separate thread and wakes the main thread to update the progress dialog from time to time. Maybe someone with in-depth OpenBSD knowledge can look into this.
Comment 3 Edd Barrett 2009-01-18 22:03:26 CET
(In reply to comment #2)
> Hm, sounds like a threading bug in OpenBSD's pthread implementation. The actual
> copy runs in a separate thread and wakes the main thread to update the progress
> dialog from time to time. Maybe someone with in-depth OpenBSD knowledge can
> look into this.

I have posted the URL to this bug on ports@openbsd.org.

Where abouts in the source can I find the code for this functionality? I can have a look, but can't promise anything.

Thanks
Comment 4 Benedikt Meurer editbugs 2009-01-18 22:16:00 CET
thunar-vfs-job.* and related files.
Comment 5 Landry Breuil editbugs 2009-01-19 08:27:04 CET
Do you have FAM running ? No idea if this could be related though, i'll try to reproduce it this evening w/ and w/out FAM.
Comment 6 Edd Barrett 2009-01-19 12:49:42 CET
I am not using FAM.
Comment 7 Landry Breuil editbugs 2009-01-20 20:24:46 CET
Didn't manage to reproduce it here, either with famd running or not, but this is with thunar 0.9.93. The progressbar is still constantly updated.
I noticed that when you focus another fullscreen window, and then focus back thunar, it's a bit slow to be repainted, there is maybe the same symptom, but definitely in the end the progressbar is updated again.
I'll send the port for 4.6beta3, you'll have to retest against it.
Comment 8 Edd Barrett 2009-01-20 21:54:29 CET
Oddly I could not repro it again on a local hard disk, but it is *VERY* noticeable when copying from disk to a USB pendrive.

Try that?
Comment 9 Landry Breuil editbugs 2009-01-22 18:03:08 CET
Created attachment 2106 
backtrace for all threads

Hm right, now i can totally reproduce it when copying files over usb1. Both thunar windows and progress window seems stuck, although files are being transferred in the background. After a certain time, if i try to close progress window, i get the new xfwm4 popup 'This window might be busy and is not responding. Do you want to terminate the application? moving files...' 
Otherwise, if i wait, thunar window only refreshes when the transfer is finished.

So yes, it is definitely an issue. Attaching the trace for all threads, hope it'd be useful.
Comment 10 Landry Breuil editbugs 2009-01-28 20:57:00 CET
We're looking into this issue with kurt miller (who knows much better than me pthreads internals).. 
one of the ideas was to disable thread priority in thunar-vfs-job.c (g_source_set_priority (source, G_PRIORITY_HIGH);) because, according to kurt, posix doesn't require fairness - i.e. high priority threads can starve low prority threads, but linux's thread scheduler gives low priority threads some time slices so bugs like this get hidden..
sadly, removing this set_priority call doesn't seem to fix the issue. We'll see if we find something else..

i think the progress bar issue is not related too, because both thunar window are frozen/not repainted even before showing progress window. The effect is less seen when copying files from hard disk to hard disk, but a little bit too. Using an usb1 disk as source shows it definitely.
Comment 11 Edd Barrett 2009-04-08 11:34:34 CEST
Hi again,

Just a note to say that I am still seeing this behavior with the new version of Thunar (1.0.0) on OpenBSD-current.

Thanks
Comment 12 Nick Schermer editbugs 2012-09-26 14:14:41 CEST
Please reopen if this is still an issue with the latest Thunar release.

Bug #4831

Reported by:
Edd Barrett
Reported on: 2009-01-18
Last modified on: 2012-09-26

People

Assignee:
Jannis Pohlmann
CC List:
3 users

Version

Version:
unspecified

Attachments

Screenshot showing the bug (214.43 KB, image/png)
2009-01-18 17:43 CET , Edd Barrett
no flags
backtrace for all threads (12.47 KB, text/plain)
2009-01-22 18:03 CET , Landry Breuil
no flags

Additional information