! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
remember size of maximized windows
Status:
RESOLVED: FIXED
Severity:
enhancement

Comments

Description Yves-Alexis Perez editbugs 2008-12-08 17:49:07 CET
Hi,

a Debian user wishlisted that Thunar save the size and position of Thunar window when closing it. Thunar is never really closed, but it could be nice if, when opening a new thunar instance, it could take the last window size and position. Not sure if it would be hard to do, but it'd be nice.

Cheers,
Comment 1 Nick Schermer editbugs 2008-12-08 17:56:01 CET
Size is already saved/restorted. The position is a task for the window manager.
Comment 2 Yves-Alexis Perez editbugs 2008-12-08 17:59:20 CET
I don't have 4.6b2 here for test, but is this a 4.6 improvement? (it doesn't do that on 0.9.0, 4.4). When I maximize the window then close thunar, then rerun another instance (thunar daemon running in the background during all operation), thunar window is set at the “default” size.
Comment 3 Yves-Alexis Perez editbugs 2008-12-08 18:00:36 CET
Correction: only the maximized state is lost (but that may be a wm problem?)
Comment 4 Nick Schermer editbugs 2008-12-08 18:06:02 CET
No that's by design. Size of full screen windows is not saved.
Comment 5 Yves-Alexis Perez editbugs 2008-12-08 18:09:07 CET
(In reply to comment #4)
> No that's by design. Size of full screen windows is not saved.

Hmhm, why so? Other apps do that
Comment 6 Nick Schermer editbugs 2008-12-08 18:13:56 CET
Because... and... that's why!
Comment 7 Nick Schermer editbugs 2008-12-08 18:52:26 CET
Created attachment 2022 
Store maximize state too.

This patch store the maximize state too, but only the window 'size' when the window is not maximized.
Comment 8 Nick Schermer editbugs 2008-12-08 18:52:59 CET
And reopen...
Comment 9 Nick Schermer editbugs 2008-12-08 18:53:32 CET
Jannis what do you think? Should we restore maximized windows too?
Comment 10 rff1917 2009-08-30 22:27:57 CEST
Yes, storing the maximize state would be really great, as every time I open an instance of Thunar, I have to double-click its title bar to maximize it.
Comment 11 Johan R 2009-10-11 09:27:59 CEST
Target milestone is passed.
Please dont forget about this, i think this shortcoming annoys a lot of xfce users.
You got a patch here so it should be a quick fix.
Comment 12 MiKe 2009-10-11 14:18:50 CEST
Yep definitely! 

I would love to be able to use a maximised window whenever I start a new thunar instance. It's the best manager I've used except for this one downside, which can get annoying at times.
Comment 13 Jannis Pohlmann editbugs 2009-10-11 14:54:11 CEST
Sure, why not. Let's do it. I'm not sure we want to remember maximized + the maximized window size. We probably want the window size used before maximizing to be remembered, so remembering only the maximized state should be good enough.
Comment 14 rff1917 2009-10-16 10:03:17 CEST
Yes, exactly. IMHO, the best for *all* applications is to remember the "normal window size" and the "maximized window state", and those only.
Definitely not the "maximized window size" without the state as it is very annoying. Mousepad does this and I really don't like it.
Comment 15 Jannis Pohlmann editbugs 2009-10-16 10:16:20 CEST
commit 46c9c926b2522f9e5527ed2497b5bc5069da70af
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Fri Oct 16 12:10:40 2009 +0200

    Remember the maximize state for new windows. Patch by Nick (bug #4697).
    
    This adds a new property 'last-window-maximized' to the
    ThunarPreferences (written as LastWindowMaximized=true/false in the
    settings file). We only remember the maximize state if the last window
    was maximized. Otherwise, we remember the window size and that the
    window was not maximized at all.

Bug #4697

Reported by:
Yves-Alexis Perez
Reported on: 2008-12-08
Last modified on: 2009-10-16

People

Assignee:
Jannis Pohlmann
CC List:
4 users

Version

Attachments

Store maximize state too. (3.36 KB, patch)
2008-12-08 18:52 CET , Nick Schermer
no flags

Additional information