! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
doc (code) improvements
Status:
RESOLVED: INVALID
Severity:
trivial
Product:
Xfce-utils
Component:
General

Comments

Description Matthias Krüger 2008-07-08 10:12:08 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.14) Gecko/20080404 Iceweasel/2.0.0.14 (Debian-2.0.0.14-2)
Build Identifier: 

I noticed that the file file:///usr/share/xfce4/doc/C/index.html is not valid. There is no doctype.

Reproducible: Always

Steps to Reproduce:
1. go to http://validator.w3.org/#validate_by_input
2. copy the content of the file /usr/share/xfce4/doc/C/index.html into the white field
3. press "check"

Actual Results:  
The validator said:
"This page is not Valid (no Doctype found)!
Result: 	Failed validation, 2 Errors"

Expected Results:  
The validator should have said:
"This Page Is Valid XHTML 1.0 Strict!
Result: 	Passed validation"

I made a patch: 
file:///usr/share/xfce4/doc/C/index.html:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
   <title>Xfce Documentation</title>
   <link rel="stylesheet" href="../xfce-chunk.css" type="text/css"/>
  </head>
  <body>
   <h1>Xfce 4.4 Documentation</h1>
   <p>The documentation for Xfce 4.4 is installed with the different 
	components that make up the desktop environment. As a consequence, 
	some of the documents listed here may not be available on your system.</p>
   <p>&nbsp;</p>
   <hr/>
   <p>&nbsp;</p>
   <h2>Guides</h2>
   <p>
    <a href="xfce4-user-guide.html">Xfce 4.4 User Guide</a>
   </p>
   <p>&nbsp;</p>
   <h2>Manuals</h2>
   <ul>
    <li>
     <a href="xfce4-panel.html">Panel</a>
    </li>
    <li>
     <a href="xfwm4.html">Window Manager</a>
    </li>
    <li>
     <a href="xfce4-session.html">Session Manager</a>
    </li>
    <li>
     <a href="xfdesktop.html">Desktop Manager</a>
    </li>
    <li>
     <a href="xfce-utils.html">Utilities and Scripts</a>
    </li>
    <li>
     <a href="xfprint.html">Printing Management</a>
    </li>
    <li>
     <a href="xfce-mcs-manager.html">Settings Manager</a>
    </li>
    <li>
     <a href="xfce-mcs-plugins.html">Settings Manager Plugins</a>
    </li>
    <li>
     <a href="exo-preferred-applications.html">Preferred Applications</a>
    </li>
    <li>
     <a href="xffm.html">Filemanager</a>
    </li>
    <li>
     <a href="xfce4-appfinder.html">Application Finder</a>
    </li>
   </ul>
   <p>&nbsp;</p>
   <hr/>
   <div>
    <img class="center" src="../xfce-mouse.png" alt="image of the xfce-mouse"/>
   </div>
  </body>
</html>


file:///usr/share/xfce4/doc/xfce-chunk.css:

body 		{ font: "Vera Sans", "Arial", "Helvetica", "sans-serif"; 
    		  margin: 2em; background-color: #F3F4F8}
h1,h2,h3,h4	{ color: #11375F; }
h3              { margin-top: 1em; margin-bottom: 0; }
dt              { margin-top: 0.2em; }
a		{ font-weight: bold; text-decoration: none; }
a:link,a:active { color: #1A5593; }
a:visited	{ color: #1A5593; }
a:hover		{ color: #3366FF; text-decoration: underline; }
hr		{ background-color: #11375F; border-style: solid; }
li		{ list-style-type: square; }
dt		{ font-weight: bold; }
.programlisting { background-color: #F8F9FD; border-color: #8593B3;
		  border-width: 1px; border-style: solid; padding: 0.5em; }
.center		{ display: block;
		  margin-left: auto;
   		  margin-right: auto;}
Comment 1 Jérôme Guelfucci editbugs 2010-10-25 08:52:07 CEST
Nick, could you have a look at this? The HTML files we generate from docbook have no html doctype.

Bug #4207

Reported by:
Matthias Krüger
Reported on: 2008-07-08
Last modified on: 2012-04-18

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Attachments

Additional information